Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

update: create_graph & properties #349

Merged
merged 2 commits into from
Oct 1, 2024
Merged

update: create_graph & properties #349

merged 2 commits into from
Oct 1, 2024

Conversation

aMahanna
Copy link
Member

  • Add satellite_collections parameter to create_graph()
  • docstring fix in create_graph()
  • Return disjoint in properties()

@aMahanna aMahanna changed the title update: create_graph & properties on update: create_graph & properties Sep 30, 2024
@aMahanna aMahanna requested a review from apetenchea September 30, 2024 21:13
@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.11%. Comparing base (0f46b50) to head (83042dc).
Report is 8 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #349      +/-   ##
==========================================
- Coverage   95.94%   95.11%   -0.84%     
==========================================
  Files          26       26              
  Lines        4296     4296              
==========================================
- Hits         4122     4086      -36     
- Misses        174      210      +36     
Flag Coverage Δ
95.11% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@apetenchea apetenchea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aMahanna aMahanna merged commit cc6646f into main Oct 1, 2024
37 checks passed
@aMahanna aMahanna deleted the graph-updates branch October 1, 2024 12:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants