Remove min version requirement for rocThrust #1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rombur
approved these changes
Jan 26, 2024
It was introduced in ROCm 3.9 days. We now depend on Kokkos 4, which requires ROCm 5.2. This requiement also breaks compiling with ROCm 6, as rocThrust has SameMajorVersion CMake compatibility mode instead of AnyNewerVersion, and rocThrust coming with ROCm6 has version 3.x.
aprokop
force-pushed
the
remove_min_rocthrust
branch
from
05c4e9b to
08476d7
Compare
|
|
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The min version requirement was introduced in ROCm 3.9 days. We now depend on Kokkos 4, which requires ROCm 5.2, which comes with rocThrust 2.15.
The presence of the version requirement also breaks compiling with ROCm 6, as rocThrust has
SameMajorVersionCMake compatibility mode instead ofAnyNewerVersion, and rocThrust coming with ROCm 6 has version 3.x.Fix #1028.