Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add distributed DBSCAN verification #1218

Merged
merged 3 commits into from
Feb 27, 2025

Conversation

aprokop
Copy link
Contributor

@aprokop aprokop commented Feb 27, 2025

  • Refactor existing DBSCAN verification to allow it to work with both local and distributed cases
  • Add (partial) distributed DBSCAN verification
    The missing part is making sure cluster IDs are unique. For local, it uses DFS. Don't know how to implement it in distributed.

@aprokop aprokop added the testing Anything to do with tests and CI label Feb 27, 2025
@aprokop aprokop force-pushed the distributed_dbscan_verification branch from abc03f6 to aceda75 Compare February 27, 2025 14:06
@aprokop aprokop force-pushed the distributed_dbscan_verification branch from aceda75 to bb815ac Compare February 27, 2025 17:57
@aprokop aprokop force-pushed the distributed_dbscan_verification branch from c216144 to 271aed7 Compare February 27, 2025 18:57
Comment on lines -322 to +417
ArborX::BoundingVolumeHierarchy bvh(
exec_space, ArborX::Experimental::attach_indices(points));
// FIXME_NVCC: nvcc 11.7 (and maybe others) cannot compile this without
// template arguments.
ArborX::DistributedTree<MemorySpace,
PairValueIndex<typename Points::value_type, unsigned>>
index(comm, exec_space, ArborX::Experimental::attach_indices(points));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The DistributedTree's deduction guide cannot be compiled here by NVCC. In other places it compiles. No idea why, but not spending time to investigate.

@aprokop
Copy link
Contributor Author

aprokop commented Feb 27, 2025

Unrelated (but real) failure on SYCL:

Running 240 test cases...
/var/jenkins/workspace/ArborX_PR-1218/test/tstQueryTreeComparisonWithBoost.cpp(188): error: in "ComparisonWithBoost/boost_rtree_spatial_predicate<TreeExecutionAndMemorySpaces<ArborX_Legacy_BVH_KDOP18_double_ Kokkos__Device<Kokkos__Experimental__SYCL_ Kokkos__Experimental__SYCLDeviceUSMSpace>>>": check query(ExecutionSpace{}, tree, intersects_queries) == (query(ExecutionSpace{}, rtree, intersects_queries_host)) has failed
  - mismatch at position 16: [( ) == ( 228 229 239 240 )] is false

*** 1 failure is detected in the test module "Master Test Suite"

Not going to do anything about it in this PR.

@aprokop aprokop merged commit f5fff89 into arborx:master Feb 27, 2025
1 of 2 checks passed
@aprokop aprokop deleted the distributed_dbscan_verification branch February 27, 2025 21:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
testing Anything to do with tests and CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant