Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Improve readability of the Clang-Tidy configuration file #1219

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Improve readability of the Clang-Tidy configuration file #1219

wants to merge 2 commits into from

Conversation

dalg24
Copy link
Contributor

@dalg24 dalg24 commented Feb 28, 2025

I did not add not remove any check, just reformatted the list to increase readability

@aprokop
Copy link
Contributor

aprokop commented Feb 28, 2025

Something has changed. Now there are errors like

<snip>/ArborX_PR-1219/examples/raytracing/example_raytracing.cpp:140:17: error:
2 uninitialized fields at the end of the constructor call [clang-analyzer-optin.cplusplus.UninitializedObject,-warnings-as-errors]

@dalg24
Copy link
Contributor Author

dalg24 commented Feb 28, 2025 •
edited
Loading

I moved -*, first
I wonder if our having it where it was before effectively disabled clang-diagnostic-* and clang-analyzer-* 😨

@aprokop
Disable one clang-analyzer check
45946b6 
See bug: llvm/llvm-project#61919
First fixed in Clang 18.1.0
@aprokop
Copy link
Contributor

aprokop commented Mar 3, 2025

Disabled clang-analyzer-optin.cplusplus.UninitializedObject check due to llvm/llvm-project#61919. Would need Clang 18.1.0+ to reenable.

@aprokop aprokop marked this pull request as draft March 5, 2025 13:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dalg24 @aprokop