Update tree query to take execution space argument #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ds take the execution space as first parameter
…e as first parameter
|
I dropped commits that were getting rid of the We can revisit later. |
dalg24
commented
Mar 27, 2020
| @@ -90,6 +88,8 @@ sortObjects(ViewType &view) | |||
| bin_sort(view, CompType(n / 2, result.min_val, result.max_val), true); | |||
| bin_sort.create_permute_vector(); | |||
| bin_sort.sort(view); | |||
| // FIXME Kokkos::BinSort is currently missing overloads that an execution | |||
| // space as argument | |||
There was a problem hiding this comment.
Need to report that on the Kokkos side and fix
There was a problem hiding this comment.
Please link it here when you open the issue there.
dalg24
commented
Mar 27, 2020
|
|
||
| auto permute_ptr = thrust::device_ptr<size_t>(permute.data()); | ||
| auto begin_ptr = thrust::device_ptr<ValueType>(view.data()); | ||
| auto end_ptr = thrust::device_ptr<ValueType>(view.data() + n); | ||
| thrust::sort_by_key(begin_ptr, end_ptr, permute_ptr); | ||
| thrust::sort_by_key(execution_policy, begin_ptr, end_ptr, permute_ptr); |
There was a problem hiding this comment.
Making sure you see saw that
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.