-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Update tree query to take execution space argument #250
Conversation
…ds take the execution space as first parameter
…e as first parameter
I dropped commits that were getting rid of the We can revisit later. |
@@ -90,6 +88,8 @@ sortObjects(ViewType &view) | |||
bin_sort(view, CompType(n / 2, result.min_val, result.max_val), true); | |||
bin_sort.create_permute_vector(); | |||
bin_sort.sort(view); | |||
// FIXME Kokkos::BinSort is currently missing overloads that an execution | |||
// space as argument |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to report that on the Kokkos side and fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please link it here when you open the issue there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty straightforward.
|
||
auto permute_ptr = thrust::device_ptr<size_t>(permute.data()); | ||
auto begin_ptr = thrust::device_ptr<ValueType>(view.data()); | ||
auto end_ptr = thrust::device_ptr<ValueType>(view.data() + n); | ||
thrust::sort_by_key(begin_ptr, end_ptr, permute_ptr); | ||
thrust::sort_by_key(execution_policy, begin_ptr, end_ptr, permute_ptr); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making sure you see saw that
No description provided.