Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Moving least squares (extra fixes) #992

Merged
merged 15 commits into from
Dec 27, 2023
Merged

Conversation

mrlag31
Copy link
Contributor

@mrlag31 mrlag31 commented Dec 22, 2023

This adds miscellaneous fixes for #946. Those are the fixes in no particular order:

  • New lines at the end of files
  • Using AccessValues instead of AccessTraits
  • Rework of internal MovingLeastSquares class
    • Usage of callbacks to create the indices and source_view views
  • Removing unnecessary KOKKOS_FUNCTION and KOKKOS_INLINE_FUNCTION
  • Removing slice_lengths static reference in evaluatePolyBasis
  • Renaming types and acronyms
  • Templation of CRBFs on the point type
    • New template parameter that takes the dimension
    • New global function that evaluates a CRBF on a point and with a specific radius.

This PR is here to discuss how to split off the changes and track them. It is not for immediate merge.

@mrlag31 mrlag31 force-pushed the mls-extra-fixes branch 2 times, most recently from 4d00940 to 620ac7e Compare December 27, 2023 14:46
@mrlag31
Copy link
Contributor Author

mrlag31 commented Dec 27, 2023

This is also the base for two extra features

@mrlag31 mrlag31 marked this pull request as ready for review December 27, 2023 16:44
@aprokop aprokop merged commit 1dc256d into arborx:master Dec 27, 2023
@aprokop aprokop mentioned this pull request Dec 27, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants