-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Deprecate exclusivePrefixSum, accumulate, adjacentDifference, iota and provide KokkosExt ones #999
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you not introduce the initial value trailing argument with exclusive_scan
if the intent is to align with standard parallel algorithms?
|
7a8f25b
to
287ea35
Compare
I don't think either of these are necessary (but it's easy to change since we don't care about backward-compatibility in that namespace). |
|
||
Kokkos::View<int[6], DeviceType> v("v"); | ||
Kokkos::deep_copy(v, 5); | ||
BOOST_TEST(KokkosExt::reduce(space, v, 3) == 33); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a using-declaration and do unqualified call here and below
using ArborX::Details::KokkosExt::reduce;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer the way I did it.
|
||
BOOST_AUTO_TEST_CASE_TEMPLATE(exclusive_scan, DeviceType, ARBORX_DEVICE_TYPES) | ||
{ | ||
namespace KokkosExt = ArborX::Details::KokkosExt; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefet
namespace KokkosExt = ArborX::Details::KokkosExt; | |
using ArborX::Details::KokkosExt::exclusive_scan; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would really like you to switch to using declaration in the unit test but I am not blocking
ArborX::exclusivePrefixSum
->ArborX::Details::KokkosExt::exclusive_scan
ArborX::accumulate
->ArborX::Details::KokkosExt::reduce
ArborX::adjacentDifference
->ArborX::Details::KokkosExt::adjacent_difference
ArborX::iota
->ArborX::Details::KokkosExt::iota
Things I'm not sure about:
KokkosExt::StdAlgorithms
namespace?iota
be inStdAlgorithms
?The goal of this and #998 is that
ArborX_DetailsUtils.hpp
is pretty clean post removal of deprecations, and nothing inArborX::
namespace.