Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Aegisub will crash if loaded avs without audio #61

Closed
seiya-git opened this issue Jul 8, 2023 · 6 comments
Closed

Aegisub will crash if loaded avs without audio #61

seiya-git opened this issue Jul 8, 2023 · 6 comments

Comments

@seiya-git
Copy link

When loading avs script, I got this error and Aegisub will crash

Default vapoursynth audio script:
import vapoursynth as vs
vs.core.bas.Source(source=filename).set_output()
@arch1t3cht
Copy link
Owner

Does this still happen with the updated provider loading logic? If so, can you give detailed steps to reproduce?

@seiya-git
Copy link
Author

seiya-git commented Sep 13, 2023 •
edited
Loading

image
Yes

just trying open avs via drug-n-drop:
FFMS2("any_video.mp4", atrack=-2)
it's happened because it will try open audio too from file

@seiya-git seiya-git mentioned this issue Oct 3, 2023
Closed
arch1t3cht added a commit that referenced this issue Oct 15, 2023
@arch1t3cht
Further fixes to audio/video provider selection
39fc834 
- Fix selection not aborting when the preferred provider returns null
- Fix the default video provider being "ffmpegsource" (lowercase)
  instead of "FFmpegSource", which would trip up provider selection
- More generally, make sure the preferred video provider actually exists
  and fall back to the default (FFmpegSource) if not.

Fixes #23 .
Fixes #61 .
Fixes #83 .
@arch1t3cht
Copy link
Owner

Should be fixed now, see #83 (comment) for more information. Reopen if this still happens.

@seiya-git
Copy link
Author

@arch1t3cht not fixed for me

when dran-n-drop avisynth script:
image
after selecting any of them, it's get error
image
image
and after closing error window and click play, Aegisub silently closes

arch1t3cht added a commit that referenced this issue Oct 15, 2023
@arch1t3cht
Further fixes to audio/video provider selection
dd3016a 
- Fix selection not aborting when the preferred provider returns null
- Fix the default video provider being "ffmpegsource" (lowercase)
  instead of "FFmpegSource", which would trip up provider selection
- More generally, make sure the preferred video provider actually exists
  and fall back to the default (FFmpegSource) if not.

Fixes #23 .
Fixes #61 .
Fixes #83 .
arch1t3cht added a commit that referenced this issue Oct 15, 2023
@arch1t3cht
avisynth: Decrease refcount again when constructor fails
858f4ac 
Proper fix to the issue that f5a730f
was trying to fix.

Fixes #61 .
@arch1t3cht
Copy link
Owner

I see, that was a separate issue with the avisynth wrap on top of the audio/video provider selection issue. Fixed now.

0tkl pushed a commit to 0tkl/Aegisub that referenced this issue Oct 16, 2023
@arch1t3cht @0tkl
Further fixes to audio/video provider selection
4fde3a7 
- Fix selection not aborting when the preferred provider returns null
- Fix the default video provider being "ffmpegsource" (lowercase)
  instead of "FFmpegSource", which would trip up provider selection
- More generally, make sure the preferred video provider actually exists
  and fall back to the default (FFmpegSource) if not.

Fixes arch1t3cht#23 .
Fixes arch1t3cht#61 .
Fixes arch1t3cht#83 .
@seiya-git
Copy link
Author

Thanks, with 858f4ac it's working now

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seiya-git @arch1t3cht