Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Problem: pre-commit dependencies conflict with each other #1693

Closed
9 of 14 tasks
replaceafill opened this issue May 24, 2024 · 0 comments
Closed
9 of 14 tasks

Problem: pre-commit dependencies conflict with each other #1693

replaceafill opened this issue May 24, 2024 · 0 comments
Milestone

Comments

@replaceafill
Copy link
Member

replaceafill commented May 24, 2024

Please describe the problem you'd like to be solved

The latest versions of our code formatter, black, conflict with our import sorting package, reorder-python-imports. See psf/black#4175

This has forced us to pin black to an old version in all our Python packages.

Describe the solution you'd like to see implemented

Many open source Python projects, including a3m, have moved to using ruff instead of black for code formatting. ruff also includes import sorting capabilities and might allow us to drop other pre-commit dependencies like flake8 and pyupgrade.

Describe alternatives you've considered

Replacing reorder-python-imports with isort.

Additional context

Affected projects:

  • artefactual-labs/agentarchives
  • artefactual-labs/amclient
  • artefactual-labs/ammcpc
  • artefactual-labs/archivematica-acceptance-tests
  • artefactual-labs/mets-reader-writer
  • artefactual/archivematica
  • artefactual/archivematica-storage-service
  • artefactual/automation-tools
  • artefactual/fixity

For Artefactual use:

Before you close this issue, you must check off the following:

  • All pull requests related to this issue are properly linked
  • All pull requests related to this issue have been merged
  • A testing plan for this issue has been implemented and passed (testing plan information should be included in the issue body or comments)
  • Documentation regarding this issue has been written and merged
  • Details about this issue have been added to the release notes
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants