Import helpers in local and production settings #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The base settings module used to import the get_env_variable helper but didn't use it. It was indirectly imported from the local and production settings modules. When Ruff was initially run on the repository it detected the unused import and "fixed" it breaking the other modules. This imports the helpers needed explicitly from each settings module and it also moves the ignored "noqa" pragmas into Ruffs configuration file.
Dhwaniartefact
approved these changes
May 29, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
basesettings module used to import theget_env_variablehelper but didn't use it. It was indirectly imported from thelocalandproductionsettings modules using star imports:When Ruff was initially run on the repository it detected the unused import and "fixed" (removed) it which broke the other modules.
This PR imports the helpers needed explicitly from each settings module and it also moves the ignored
noqapragmas into Ruffs configuration file.Connected to archivematica/Issues#1693