Use YYYYMMDD for crawl_date for DomainGraphExtractor. #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Resolves #544 - Update DomainGraphExtractor test - Add import scala.language.postfixOps to resolve "postfix operator isNotNull should be enabled by making the implicit value scala.language.postfixOps visible."
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #545 +/- ##
=========================================
Coverage 93.87% 93.87%
Complexity 48 48
=========================================
Files 44 44
Lines 980 980
Branches 52 52
=========================================
Hits 920 920
Misses 36 36
Partials 24 24 |
ianmilligan1
approved these changes
Oct 31, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub issue(s): #544
What does this Pull Request do?
How should this be tested?
Tests should take care of it.
I'll cut a 1.1.1 release once we get this merged.