Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Edjroz/enhancement/test coverage releases #164

Merged
merged 10 commits into from
May 16, 2022

Conversation

edjroz
Copy link
Contributor

@edjroz edjroz commented May 11, 2022

@edjroz edjroz requested a review from aelesbao May 11, 2022 15:49
@edjroz edjroz force-pushed the edjroz/enhancement/test-coverage-releases branch from 515180d to ad358cd Compare May 11, 2022 16:26
@edjroz edjroz force-pushed the edjroz/enhancement/test-coverage-releases branch from ad358cd to 65ed9ac Compare May 11, 2022 16:29
@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@d81d023). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #164   +/-   ##
=======================================
  Coverage        ?   55.26%           
=======================================
  Files           ?       18           
  Lines           ?     1283           
  Branches        ?        0           
=======================================
  Hits            ?      709           
  Misses          ?      528           
  Partials        ?       46           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d81d023...b6e5a90. Read the comment docs.

.github/workflows/release.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
run: |
VERSION=${{ steps.get_version.outputs.VERSION }} DB_BACKEND=${{ matrix.db_backend }} make build
tar -czvf archwayd_${{ steps.get_version.outputs.VERSION }}_${{ matrix.os }}.tar.gz build/archwayd
- uses: actions/upload-artifact@v2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actions/upload-artifact@v2 action is to upload artifacts to workflow runs so that the next step can download them. To add assets to a GitHub release, you should use an action that interacts with the Releases API.

edjroz and others added 6 commits May 11, 2022 14:42
Co-authored-by: Augusto Elesbão <aelesbao@users.noreply.github.com>
Co-authored-by: Augusto Elesbão <aelesbao@users.noreply.github.com>
…m:archway-network/archway into edjroz/enhancement/test-coverage-releases
@edjroz edjroz merged commit 39c98ea into main May 16, 2022
@edjroz edjroz deleted the edjroz/enhancement/test-coverage-releases branch May 16, 2022 23:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants