Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: remove deprecated request functionality #543

Merged

Conversation

stijnmoreels
Copy link
Member

Remove deprecated functionality related to request tracking in preperation to the v3 release.

Closes #404
Closes #397

@netlify
Copy link

netlify bot commented Oct 10, 2023

Deploy Preview for arcus-observability canceled.

Name Link
🔨 Latest commit b5410a9
🔍 Latest deploy log https://app.netlify.com/sites/arcus-observability/deploys/6524dd9f80329a00089d4f46

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (14e17ad) 85.71% compared to head (b5410a9) 85.58%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #543      +/-   ##
==========================================
- Coverage   85.71%   85.58%   -0.14%     
==========================================
  Files          71       71              
  Lines        3095     2955     -140     
  Branches      217      194      -23     
==========================================
- Hits         2653     2529     -124     
- Misses        365      366       +1     
+ Partials       77       60      -17     
Files Coverage Δ
....AspNetCore/Extensions/ILoggerRequestExtensions.cs 88.57% <ø> (+19.34%) ⬆️
...emetry.Core/Extensions/ILoggerRequestExtensions.cs 94.02% <100.00%> (+23.19%) ⬆️
...vability.Telemetry.Core/Logging/RequestLogEntry.cs 97.29% <ø> (+2.05%) ⬆️
...onInsights/Converters/RequestTelemetryConverter.cs 4.22% <ø> (-56.02%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fgheysels
Copy link
Member

It looks like we're using some obsolete 'LogMetric' and other obsolete Log Dependency methods here. We should replace them by the non-obsolete methods

@stijnmoreels
Copy link
Member Author

It looks like we're using some obsolete 'LogMetric' and other obsolete Log Dependency methods here. We should replace them by the non-obsolete methods

All in good time #398, #404, #401, #424, #428... it was too big to remove all in a single PR, that's why this PR only handles the deprecated request-related functionality.

@stijnmoreels stijnmoreels merged commit 1a4016c into arcus-azure:main Nov 14, 2023
@stijnmoreels stijnmoreels deleted the chore/remove-deprecated-request branch November 14, 2023 06:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
2 participants