-
-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Pass through all possible stitching errors #1147
Conversation
Just to comment on graphql-tools-fork, where this pull request will likely actually be merged soon. In general, the aim of the fork is to (A) actually get fixes merged and (B) stop the deprecations of useful functionality. In particular, I think schema stitching/delegation should not be deprecated -- it seems still very useful, especially with delegation to external GraphQL APIs. One stated rationale for deprecation was that schema stitching is brittle; I think merging bug fixes will show that it is less brittle than thought. :) I also believe that there may exist simpler solutions to the problems that schema federation is meant to solve, and that the schema delegation/stitching API gives the community the low-level tools to continue to experiment. More on this when time allows and in separate issues. |
Comments, feedback, opposing viewpoints welcome! |
e4b5c63
to
0771ccf
Compare
Released to graphql-tools-fork as v5.1.0. |
0771ccf
to
e157293
Compare
Use new relocatedError function to update the original GraphQLErrors with the new path.
e157293
to
595627a
Compare
@yaacovCR I'm hitting the same error. Was this PR superseded by something else or did you close it because you received no response? |
Nevemind, found #1206 👍 |
This PR aims to solve the same issues as #1074 (i.e., #743, #1037, #1046, apollographql/apollo-server#1582).
It does so by:
TODO (finished)