Skip to content

Improved parse to support converting comments into descriptions #1900

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Aug 11, 2020

Conversation

dotansimha
Copy link
Collaborator

@dotansimha dotansimha commented Aug 11, 2020

The PR includes fixes for:

  • Allow transforming old GraphQL comments into GraphQL descriptions (during parse), using the same commentDescriptions configuration flag (it's a workaround for Maintain comments when parsing schema graphql/graphql-js#2241)
  • Use custom parse in all relevant pieces of code.
  • Ensure empty document isn't throwing errors during parsing.

@theguild-bot
Copy link
Collaborator

theguild-bot commented Aug 11, 2020

The latest changes of this PR are available as alpha in npm: 6.0.18-alpha-46c5700a.0

Quickly update your package.json by running:

npx match-version @graphql-tools 6.0.18-alpha-46c5700a.0

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants