Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixes #905 #907

Closed
Closed

Conversation

stevefan1999-personal
Copy link

@stevefan1999-personal stevefan1999-personal commented Jul 26, 2018

TODO:

  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change. Include a description of your change, link to PR (always) and issue (if applicable). Add your CHANGELOG entry under vNEXT. Do not create a new version number for your change yourself.
  • If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)

This PR addresses the issue on remote schemas that primitive values are being wrongfully annotated with a symbol whenever there is an error, and it also addresses error resolution to use the server-provided diagnostic information whenever possible (location is still resolved on the stitching proxy side) or otherwise, fall back to the old behavior (i.e. join error messages with newlines).

@apollo-cla
Copy link

@stevefan1999: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@apollo-cla
Copy link

@stevefan1999: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@ghost ghost added feature New addition or enhancement to existing solutions labels Jul 26, 2018
@stevefan1999-personal
Copy link
Author

Can I not provide the mailing address? I don't want my personal information be invaded by another inch...

@stubailo
Copy link
Contributor

Hi, can you please add a description for what issue this PR is intended to fix? I see some of the discussion in #905 but it's hard to follow what the specific issues are that this is addressing. That way, I can review if the intended outcome was achieved.

@ghost ghost added the feature New addition or enhancement to existing solutions label Aug 1, 2018
@stevefan1999-personal
Copy link
Author

cc @stubailo I've updated my PR description and merged the ChangeLog, there are two little things to fix in a nutshell.

@ghost ghost added the feature New addition or enhancement to existing solutions label Aug 1, 2018
@ghost ghost added the feature New addition or enhancement to existing solutions label Aug 14, 2018
@yaacovCR
Copy link
Collaborator

yaacovCR commented Apr 1, 2020

Closed in favor of #1307

@yaacovCR yaacovCR closed this Apr 1, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
feature New addition or enhancement to existing solutions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants