-
-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fixes #905 #907
Fixes #905 #907
Conversation
@stevefan1999: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
@stevefan1999: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
Can I not provide the mailing address? I don't want my personal information be invaded by another inch... |
Hi, can you please add a description for what issue this PR is intended to fix? I see some of the discussion in #905 but it's hard to follow what the specific issues are that this is addressing. That way, I can review if the intended outcome was achieved. |
cc @stubailo I've updated my PR description and merged the ChangeLog, there are two little things to fix in a nutshell. |
Closed in favor of #1307 |
TODO:
This PR addresses the issue on remote schemas that primitive values are being wrongfully annotated with a symbol whenever there is an error, and it also addresses error resolution to use the server-provided diagnostic information whenever possible (location is still resolved on the stitching proxy side) or otherwise, fall back to the old behavior (i.e. join error messages with newlines).