Add counter support feature #50
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Memory usage change @ 0fe82c9
Click for full report table
Click for full report CSV |
per1234
added
type: enhancement
pennam
requested changes
Sep 18, 2023
Comment on lines
+551
to
+573
| long ECCX08Class::incrementCounter(int keyId) | ||
| { | ||
| uint32_t counter; // the counter can go up to 2,097,151 | ||
|
|
||
| if (!wakeup()) { | ||
| return -1; | ||
| } | ||
|
|
||
| if (!sendCommand(0x24, 1, keyId)) { | ||
| return -1; | ||
| } | ||
|
|
||
| delay(20); | ||
|
|
||
| if (!receiveResponse(&counter, sizeof(counter))) { | ||
| return -1; | ||
| } | ||
|
|
||
| delay(1); | ||
| idle(); | ||
|
|
||
| return counter; | ||
| } |
There was a problem hiding this comment.
To keep changes aligned to the style of the library i would split this function in two:
- one basic function returning 0 or 1 and taking the counter value as argument;
- another one that wraps it and returns the counter value
Also, reading the docs it looks to me that keyId can be only 0 or 1 so i would add a check to keyId parameter.
Suggested change
| long ECCX08Class::incrementCounter(int keyId) | |
| { | |
| uint32_t counter; // the counter can go up to 2,097,151 | |
| if (!wakeup()) { | |
| return -1; | |
| } | |
| if (!sendCommand(0x24, 1, keyId)) { | |
| return -1; | |
| } | |
| delay(20); | |
| if (!receiveResponse(&counter, sizeof(counter))) { | |
| return -1; | |
| } | |
| delay(1); | |
| idle(); | |
| return counter; | |
| } | |
| int ECCX08Class::incrementCounter(int keyId, long& counter) | |
| { | |
| if (keyId < 0 || keyId > 1) { | |
| return 0; | |
| } | |
| if (!wakeup()) { | |
| return 0; | |
| } | |
| if (!sendCommand(0x24, 1, keyId)) { | |
| return 0; | |
| } | |
| delay(20); | |
| if (!receiveResponse(&counter, sizeof(counter))) { | |
| return 0; | |
| } | |
| delay(1); | |
| idle(); | |
| return 1; | |
| } | |
| long ECCX08Class::incrementCounter(int keyId) | |
| { | |
| long counter; // the counter can go up to 2,097,151 | |
| if(!incrementCounter(keyId, counter)) { | |
| return -1; | |
| } | |
| return counter; | |
| } |
| idle(); | ||
|
|
||
| return counter; | ||
| } |
| @@ -66,6 +66,9 @@ class ECCX08Class | |||
|
|
|||
| int nonce(const byte data[]); | |||
|
|
|||
| long incrementCounter(int keyId); | |||
There was a problem hiding this comment.
And update methods declarations accordingly.
|
superseded by #53 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.