Skip to content

Avoid using memcpy to store timezone data #467

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
May 27, 2024

Conversation

pennam
Copy link
Collaborator

@pennam pennam commented May 27, 2024

Fix bug introduced in #451 causing a board reset when ResetCmdId is sent to thing process handling a disconnection.

Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.26%. Comparing base (335daf8) to head (3069915).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #467   +/-   ##
=======================================
  Coverage   95.26%   95.26%           
=======================================
  Files          32       32           
  Lines        1478     1478           
=======================================
  Hits         1408     1408           
  Misses         70       70           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Memory usage change @ 3069915

Board flash % RAM for global variables %
arduino:esp32:nano_nora 💚 -60 - -52 -0.0 - -0.0 💚 -336 - -336 -0.1 - -0.1
arduino:mbed_edge:edge_control 💚 -64 - 0 -0.01 - 0.0 💚 -336 - -336 -0.13 - -0.13
arduino:mbed_giga:giga 💚 -64 - 0 -0.0 - 0.0 💚 -352 - 0 -0.07 - 0.0
arduino:mbed_nano:nanorp2040connect 💚 -132 - 0 -0.0 - 0.0 💚 -336 - 0 -0.12 - 0.0
arduino:mbed_nicla:nicla_vision 💚 -64 - 0 -0.0 - 0.0 💚 -352 - 0 -0.07 - 0.0
arduino:mbed_opta:opta 💚 -64 - 0 -0.0 - 0.0 💚 -352 - 0 -0.07 - 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 💚 -40 - 0 -0.0 - 0.0 💚 -352 - 0 -0.07 - 0.0
arduino:renesas_uno:unor4wifi 💚 -48 - -32 -0.02 - -0.01 💚 -336 - -336 -1.03 - -1.03
arduino:samd:mkr1000 💚 -136 - 0 -0.05 - 0.0 💚 -336 - 0 -1.03 - 0.0
arduino:samd:mkrgsm1400 💚 -136 - 0 -0.05 - 0.0 💚 -336 - 0 -1.03 - 0.0
arduino:samd:mkrnb1500 💚 -136 - 0 -0.05 - 0.0 💚 -336 - 0 -1.03 - 0.0
arduino:samd:mkrwan1300 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrwifi1010 💚 -160 - 0 -0.06 - 0.0 💚 -336 - 0 -1.03 - 0.0
arduino:samd:nano_33_iot 💚 -160 - 0 -0.06 - 0.0 💚 -336 - 0 -1.03 - 0.0
esp32:esp32:esp32 💚 -56 - -52 -0.0 - -0.0 💚 -336 - -336 -0.1 - -0.1
esp8266:esp8266:huzzah 💚 -80 - -80 -0.01 - -0.01 💚 -336 - -336 -0.41 - -0.41
Click for full report table
Board examples/ArduinoIoTCloud-Advanced
flash
% examples/ArduinoIoTCloud-Advanced
RAM for global variables
% examples/ArduinoIoTCloud-Basic
flash
% examples/ArduinoIoTCloud-Basic
RAM for global variables
% examples/ArduinoIoTCloud-Callbacks
flash
% examples/ArduinoIoTCloud-Callbacks
RAM for global variables
% examples/ArduinoIoTCloud-Schedule
flash
% examples/ArduinoIoTCloud-Schedule
RAM for global variables
% examples/utility/ArduinoIoTCloud_Travis_CI
flash
% examples/utility/ArduinoIoTCloud_Travis_CI
RAM for global variables
% examples/ArduinoIoTCloud-DeferredOTA
flash
% examples/ArduinoIoTCloud-DeferredOTA
RAM for global variables
% examples/utility/Provisioning
flash
% examples/utility/Provisioning
RAM for global variables
% examples/utility/SelfProvisioning
flash
% examples/utility/SelfProvisioning
RAM for global variables
%
arduino:esp32:nano_nora -56 -0.0 -336 -0.1 -60 -0.0 -336 -0.1 -52 -0.0 -336 -0.1 -52 -0.0 -336 -0.1 -56 -0.0 -336 -0.1 -52 -0.0 -336 -0.1
arduino:mbed_edge:edge_control 0 0.0 -336 -0.13 -64 -0.01 -336 -0.13 0 0.0 -336 -0.13 -64 -0.01 -336 -0.13 0 0.0 -336 -0.13
arduino:mbed_giga:giga 0 0.0 -352 -0.07 0 0.0 -320 -0.06 -64 -0.0 -352 -0.07 0 0.0 -320 -0.06 0 0.0 -320 -0.06 0 0.0 -352 -0.07 0 0.0 0 0.0
arduino:mbed_nano:nanorp2040connect -132 -0.0 -336 -0.12 -132 -0.0 -336 -0.12 -132 -0.0 -336 -0.12 -132 -0.0 -336 -0.12 -132 -0.0 -336 -0.12 -132 -0.0 -336 -0.12 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_nicla:nicla_vision 0 0.0 -320 -0.06 -64 -0.0 -352 -0.07 -64 -0.0 -320 -0.06 0 0.0 -352 -0.07 -64 -0.0 -352 -0.07 0 0.0 -320 -0.06 0 0.0 0 0.0
arduino:mbed_opta:opta 0 0.0 -320 -0.06 0 0.0 -352 -0.07 0 0.0 -320 -0.06 0 0.0 -352 -0.07 -64 -0.0 -352 -0.07 0 0.0 -320 -0.06 0 0.0 0 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 -40 -0.0 -352 -0.07 -40 -0.0 -320 -0.06 -40 -0.0 -352 -0.07 -40 -0.0 -320 -0.06 -40 -0.0 -320 -0.06 0 0.0 0 0.0
arduino:renesas_uno:unor4wifi -48 -0.02 -336 -1.03 -32 -0.01 -336 -1.03 -48 -0.02 -336 -1.03 -48 -0.02 -336 -1.03 -32 -0.01 -336 -1.03
arduino:samd:mkr1000 -136 -0.05 -336 -1.03 -136 -0.05 -336 -1.03 -136 -0.05 -336 -1.03 -136 -0.05 -336 -1.03 -136 -0.05 -336 -1.03 0 0.0 0 0.0
arduino:samd:mkrgsm1400 -136 -0.05 -336 -1.03 -136 -0.05 -336 -1.03 -136 -0.05 -336 -1.03 -136 -0.05 -336 -1.03 -136 -0.05 -336 -1.03 0 0.0 0 0.0
arduino:samd:mkrnb1500 -136 -0.05 -336 -1.03 -136 -0.05 -336 -1.03 -136 -0.05 -336 -1.03 -136 -0.05 -336 -1.03 -136 -0.05 -336 -1.03 0 0.0 0 0.0
arduino:samd:mkrwan1300 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:mkrwifi1010 -160 -0.06 -336 -1.03 -160 -0.06 -336 -1.03 -160 -0.06 -336 -1.03 -160 -0.06 -336 -1.03 -160 -0.06 -336 -1.03 -160 -0.06 -336 -1.03 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:nano_33_iot -160 -0.06 -336 -1.03 -160 -0.06 -336 -1.03 -160 -0.06 -336 -1.03 -160 -0.06 -336 -1.03 -160 -0.06 -336 -1.03 -160 -0.06 -336 -1.03 0 0.0 0 0.0 0 0.0 0 0.0
esp32:esp32:esp32 -52 -0.0 -336 -0.1 -52 -0.0 -336 -0.1 -56 -0.0 -336 -0.1 -56 -0.0 -336 -0.1 -52 -0.0 -336 -0.1 -56 -0.0 -336 -0.1
esp8266:esp8266:huzzah -80 -0.01 -336 -0.41 -80 -0.01 -336 -0.41 -80 -0.01 -336 -0.41 -80 -0.01 -336 -0.41 -80 -0.01 -336 -0.41
Click for full report CSV
Board,examples/ArduinoIoTCloud-Advanced<br>flash,%,examples/ArduinoIoTCloud-Advanced<br>RAM for global variables,%,examples/ArduinoIoTCloud-Basic<br>flash,%,examples/ArduinoIoTCloud-Basic<br>RAM for global variables,%,examples/ArduinoIoTCloud-Callbacks<br>flash,%,examples/ArduinoIoTCloud-Callbacks<br>RAM for global variables,%,examples/ArduinoIoTCloud-Schedule<br>flash,%,examples/ArduinoIoTCloud-Schedule<br>RAM for global variables,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>flash,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>RAM for global variables,%,examples/ArduinoIoTCloud-DeferredOTA<br>flash,%,examples/ArduinoIoTCloud-DeferredOTA<br>RAM for global variables,%,examples/utility/Provisioning<br>flash,%,examples/utility/Provisioning<br>RAM for global variables,%,examples/utility/SelfProvisioning<br>flash,%,examples/utility/SelfProvisioning<br>RAM for global variables,%
arduino:esp32:nano_nora,-56,-0.0,-336,-0.1,-60,-0.0,-336,-0.1,-52,-0.0,-336,-0.1,-52,-0.0,-336,-0.1,-56,-0.0,-336,-0.1,-52,-0.0,-336,-0.1
arduino:mbed_edge:edge_control,0,0.0,-336,-0.13,-64,-0.01,-336,-0.13,0,0.0,-336,-0.13,-64,-0.01,-336,-0.13,0,0.0,-336,-0.13,,,,
arduino:mbed_giga:giga,0,0.0,-352,-0.07,0,0.0,-320,-0.06,-64,-0.0,-352,-0.07,0,0.0,-320,-0.06,0,0.0,-320,-0.06,0,0.0,-352,-0.07,0,0.0,0,0.0
arduino:mbed_nano:nanorp2040connect,-132,-0.0,-336,-0.12,-132,-0.0,-336,-0.12,-132,-0.0,-336,-0.12,-132,-0.0,-336,-0.12,-132,-0.0,-336,-0.12,-132,-0.0,-336,-0.12,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nicla:nicla_vision,0,0.0,-320,-0.06,-64,-0.0,-352,-0.07,-64,-0.0,-320,-0.06,0,0.0,-352,-0.07,-64,-0.0,-352,-0.07,0,0.0,-320,-0.06,0,0.0,0,0.0,,,,
arduino:mbed_opta:opta,0,0.0,-320,-0.06,0,0.0,-352,-0.07,0,0.0,-320,-0.06,0,0.0,-352,-0.07,-64,-0.0,-352,-0.07,0,0.0,-320,-0.06,0,0.0,0,0.0,,,,
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,,,,
arduino:renesas_portenta:portenta_c33,-40,-0.0,-352,-0.07,-40,-0.0,-320,-0.06,-40,-0.0,-352,-0.07,-40,-0.0,-320,-0.06,-40,-0.0,-320,-0.06,,,,,0,0.0,0,0.0,,,,
arduino:renesas_uno:unor4wifi,-48,-0.02,-336,-1.03,-32,-0.01,-336,-1.03,-48,-0.02,-336,-1.03,-48,-0.02,-336,-1.03,-32,-0.01,-336,-1.03,,,,,,,,,,,,
arduino:samd:mkr1000,-136,-0.05,-336,-1.03,-136,-0.05,-336,-1.03,-136,-0.05,-336,-1.03,-136,-0.05,-336,-1.03,-136,-0.05,-336,-1.03,,,,,0,0.0,0,0.0,,,,
arduino:samd:mkrgsm1400,-136,-0.05,-336,-1.03,-136,-0.05,-336,-1.03,-136,-0.05,-336,-1.03,-136,-0.05,-336,-1.03,-136,-0.05,-336,-1.03,,,,,0,0.0,0,0.0,,,,
arduino:samd:mkrnb1500,-136,-0.05,-336,-1.03,-136,-0.05,-336,-1.03,-136,-0.05,-336,-1.03,-136,-0.05,-336,-1.03,-136,-0.05,-336,-1.03,,,,,0,0.0,0,0.0,,,,
arduino:samd:mkrwan1300,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,,,,,,,,
arduino:samd:mkrwifi1010,-160,-0.06,-336,-1.03,-160,-0.06,-336,-1.03,-160,-0.06,-336,-1.03,-160,-0.06,-336,-1.03,-160,-0.06,-336,-1.03,-160,-0.06,-336,-1.03,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:nano_33_iot,-160,-0.06,-336,-1.03,-160,-0.06,-336,-1.03,-160,-0.06,-336,-1.03,-160,-0.06,-336,-1.03,-160,-0.06,-336,-1.03,-160,-0.06,-336,-1.03,0,0.0,0,0.0,0,0.0,0,0.0
esp32:esp32:esp32,-52,-0.0,-336,-0.1,-52,-0.0,-336,-0.1,-56,-0.0,-336,-0.1,-56,-0.0,-336,-0.1,-52,-0.0,-336,-0.1,-56,-0.0,-336,-0.1,,,,,,,,
esp8266:esp8266:huzzah,-80,-0.01,-336,-0.41,-80,-0.01,-336,-0.41,-80,-0.01,-336,-0.41,-80,-0.01,-336,-0.41,-80,-0.01,-336,-0.41,,,,,,,,,,,,

@pennam pennam requested a review from andreagilardoni May 27, 2024 10:18
@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels May 27, 2024
@pennam pennam merged commit 06613dd into arduino-libraries:master May 27, 2024
23 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants