Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix time validity check to account for maximum possible timezone offset #509

Merged
merged 4 commits into from
Sep 16, 2024

Conversation

pennam
Copy link
Collaborator

@pennam pennam commented Sep 16, 2024

No description provided.

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.39%. Comparing base (0383d65) to head (278f653).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #509   +/-   ##
=======================================
  Coverage   95.39%   95.39%           
=======================================
  Files          33       33           
  Lines        1520     1520           
=======================================
  Hits         1450     1450           
  Misses         70       70           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Memory usage change @ 278f653

Board flash % RAM for global variables %
arduino:esp32:nano_nora 🔺 +104 - +208 0.0 - +0.01 0 - 0 0.0 - 0.0
arduino:mbed_edge:edge_control 🔺 +144 - +224 +0.01 - +0.02 0 - 0 0.0 - 0.0
arduino:mbed_giga:giga 🔺 0 - +224 0.0 - +0.01 0 - 0 0.0 - 0.0
arduino:mbed_nano:nanorp2040connect 🔺 0 - +186 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_nicla:nicla_vision 🔺 0 - +224 0.0 - +0.01 0 - 0 0.0 - 0.0
arduino:mbed_opta:opta 🔺 0 - +224 0.0 - +0.01 0 - 0 0.0 - 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 🔺 0 - +200 0.0 - +0.01 0 - 0 0.0 - 0.0
arduino:renesas_uno:unor4wifi 🔺 +96 - +200 +0.04 - +0.08 0 - 0 0.0 - 0.0
arduino:samd:mkr1000 🔺 0 - +184 0.0 - +0.07 0 - 0 0.0 - 0.0
arduino:samd:mkrgsm1400 🔺 0 - +184 0.0 - +0.07 0 - 0 0.0 - 0.0
arduino:samd:mkrnb1500 🔺 0 - +184 0.0 - +0.07 0 - 0 0.0 - 0.0
arduino:samd:mkrwan1300 🔺 0 - +88 0.0 - +0.03 0 - 0 0.0 - 0.0
arduino:samd:mkrwifi1010 🔺 0 - +184 0.0 - +0.07 0 - 0 0.0 - 0.0
arduino:samd:nano_33_iot 🔺 0 - +184 0.0 - +0.07 0 - 0 0.0 - 0.0
esp32:esp32:esp32 🔺 +112 - +224 +0.01 - +0.02 0 - 0 0.0 - 0.0
esp8266:esp8266:huzzah 🔺 +204 - +208 +0.02 - +0.02 🔺 +144 - +144 +0.18 - +0.18
Click for full report table
Board examples/ArduinoIoTCloud-Advanced
flash
% examples/ArduinoIoTCloud-Advanced
RAM for global variables
% examples/ArduinoIoTCloud-Basic
flash
% examples/ArduinoIoTCloud-Basic
RAM for global variables
% examples/ArduinoIoTCloud-Callbacks
flash
% examples/ArduinoIoTCloud-Callbacks
RAM for global variables
% examples/ArduinoIoTCloud-Schedule
flash
% examples/ArduinoIoTCloud-Schedule
RAM for global variables
% examples/utility/ArduinoIoTCloud_Travis_CI
flash
% examples/utility/ArduinoIoTCloud_Travis_CI
RAM for global variables
% examples/ArduinoIoTCloud-DeferredOTA
flash
% examples/ArduinoIoTCloud-DeferredOTA
RAM for global variables
% examples/ArduinoIoTCloud-Notecard
flash
% examples/ArduinoIoTCloud-Notecard
RAM for global variables
% examples/utility/Provisioning
flash
% examples/utility/Provisioning
RAM for global variables
% examples/utility/SelfProvisioning
flash
% examples/utility/SelfProvisioning
RAM for global variables
%
arduino:esp32:nano_nora 188 0.01 0 0.0 188 0.01 0 0.0 204 0.01 0 0.0 208 0.01 0 0.0 200 0.01 0 0.0 204 0.01 0 0.0 104 0.0 0 0.0
arduino:mbed_edge:edge_control 160 0.02 0 0.0 224 0.02 0 0.0 160 0.02 0 0.0 216 0.02 0 0.0 160 0.02 0 0.0 144 0.01 0 0.0
arduino:mbed_giga:giga 216 0.01 0 0.0 152 0.01 0 0.0 216 0.01 0 0.0 224 0.01 0 0.0 160 0.01 0 0.0 216 0.01 0 0.0 80 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_nano:nanorp2040connect 186 0.0 0 0.0 186 0.0 0 0.0 186 0.0 0 0.0 186 0.0 0 0.0 186 0.0 0 0.0 186 0.0 0 0.0 92 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_nicla:nicla_vision 160 0.01 0 0.0 224 0.01 0 0.0 160 0.01 0 0.0 160 0.01 0 0.0 224 0.01 0 0.0 160 0.01 0 0.0 80 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_opta:opta 152 0.01 0 0.0 224 0.01 0 0.0 152 0.01 0 0.0 160 0.01 0 0.0 224 0.01 0 0.0 216 0.01 0 0.0 144 0.01 0 0.0 0 0.0 0 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 200 0.01 0 0.0 192 0.01 0 0.0 200 0.01 0 0.0 200 0.01 0 0.0 184 0.01 0 0.0 104 0.0 0 0.0 0 0.0 0 0.0
arduino:renesas_uno:unor4wifi 184 0.07 0 0.0 200 0.08 0 0.0 192 0.07 0 0.0 192 0.07 0 0.0 200 0.08 0 0.0 96 0.04 0 0.0
arduino:samd:mkr1000 184 0.07 0 0.0 184 0.07 0 0.0 184 0.07 0 0.0 184 0.07 0 0.0 184 0.07 0 0.0 88 0.03 0 0.0 0 0.0 0 0.0
arduino:samd:mkrgsm1400 184 0.07 0 0.0 184 0.07 0 0.0 184 0.07 0 0.0 184 0.07 0 0.0 184 0.07 0 0.0 88 0.03 0 0.0 0 0.0 0 0.0
arduino:samd:mkrnb1500 184 0.07 0 0.0 184 0.07 0 0.0 184 0.07 0 0.0 184 0.07 0 0.0 184 0.07 0 0.0 88 0.03 0 0.0 0 0.0 0 0.0
arduino:samd:mkrwan1300 8 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 8 0.0 0 0.0 0 0.0 0 0.0 88 0.03 0 0.0
arduino:samd:mkrwifi1010 184 0.07 0 0.0 184 0.07 0 0.0 184 0.07 0 0.0 184 0.07 0 0.0 184 0.07 0 0.0 184 0.07 0 0.0 88 0.03 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:nano_33_iot 184 0.07 0 0.0 184 0.07 0 0.0 184 0.07 0 0.0 184 0.07 0 0.0 184 0.07 0 0.0 184 0.07 0 0.0 96 0.04 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
esp32:esp32:esp32 200 0.02 0 0.0 216 0.02 0 0.0 216 0.02 0 0.0 216 0.02 0 0.0 224 0.02 0 0.0 216 0.02 0 0.0 112 0.01 0 0.0
esp8266:esp8266:huzzah 208 0.02 144 0.18 208 0.02 144 0.18 208 0.02 144 0.18 204 0.02 144 0.18 208 0.02 144 0.18
Click for full report CSV
Board,examples/ArduinoIoTCloud-Advanced<br>flash,%,examples/ArduinoIoTCloud-Advanced<br>RAM for global variables,%,examples/ArduinoIoTCloud-Basic<br>flash,%,examples/ArduinoIoTCloud-Basic<br>RAM for global variables,%,examples/ArduinoIoTCloud-Callbacks<br>flash,%,examples/ArduinoIoTCloud-Callbacks<br>RAM for global variables,%,examples/ArduinoIoTCloud-Schedule<br>flash,%,examples/ArduinoIoTCloud-Schedule<br>RAM for global variables,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>flash,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>RAM for global variables,%,examples/ArduinoIoTCloud-DeferredOTA<br>flash,%,examples/ArduinoIoTCloud-DeferredOTA<br>RAM for global variables,%,examples/ArduinoIoTCloud-Notecard<br>flash,%,examples/ArduinoIoTCloud-Notecard<br>RAM for global variables,%,examples/utility/Provisioning<br>flash,%,examples/utility/Provisioning<br>RAM for global variables,%,examples/utility/SelfProvisioning<br>flash,%,examples/utility/SelfProvisioning<br>RAM for global variables,%
arduino:esp32:nano_nora,188,0.01,0,0.0,188,0.01,0,0.0,204,0.01,0,0.0,208,0.01,0,0.0,200,0.01,0,0.0,204,0.01,0,0.0,104,0.0,0,0.0
arduino:mbed_edge:edge_control,160,0.02,0,0.0,224,0.02,0,0.0,160,0.02,0,0.0,216,0.02,0,0.0,160,0.02,0,0.0,,,,,144,0.01,0,0.0
arduino:mbed_giga:giga,216,0.01,0,0.0,152,0.01,0,0.0,216,0.01,0,0.0,224,0.01,0,0.0,160,0.01,0,0.0,216,0.01,0,0.0,80,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nano:nanorp2040connect,186,0.0,0,0.0,186,0.0,0,0.0,186,0.0,0,0.0,186,0.0,0,0.0,186,0.0,0,0.0,186,0.0,0,0.0,92,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nicla:nicla_vision,160,0.01,0,0.0,224,0.01,0,0.0,160,0.01,0,0.0,160,0.01,0,0.0,224,0.01,0,0.0,160,0.01,0,0.0,80,0.0,0,0.0,0,0.0,0,0.0,,,,
arduino:mbed_opta:opta,152,0.01,0,0.0,224,0.01,0,0.0,152,0.01,0,0.0,160,0.01,0,0.0,224,0.01,0,0.0,216,0.01,0,0.0,144,0.01,0,0.0,0,0.0,0,0.0,,,,
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,,,,
arduino:renesas_portenta:portenta_c33,200,0.01,0,0.0,192,0.01,0,0.0,200,0.01,0,0.0,200,0.01,0,0.0,184,0.01,0,0.0,,,,,104,0.0,0,0.0,0,0.0,0,0.0,,,,
arduino:renesas_uno:unor4wifi,184,0.07,0,0.0,200,0.08,0,0.0,192,0.07,0,0.0,192,0.07,0,0.0,200,0.08,0,0.0,,,,,96,0.04,0,0.0,,,,,,,,
arduino:samd:mkr1000,184,0.07,0,0.0,184,0.07,0,0.0,184,0.07,0,0.0,184,0.07,0,0.0,184,0.07,0,0.0,,,,,88,0.03,0,0.0,0,0.0,0,0.0,,,,
arduino:samd:mkrgsm1400,184,0.07,0,0.0,184,0.07,0,0.0,184,0.07,0,0.0,184,0.07,0,0.0,184,0.07,0,0.0,,,,,88,0.03,0,0.0,0,0.0,0,0.0,,,,
arduino:samd:mkrnb1500,184,0.07,0,0.0,184,0.07,0,0.0,184,0.07,0,0.0,184,0.07,0,0.0,184,0.07,0,0.0,,,,,88,0.03,0,0.0,0,0.0,0,0.0,,,,
arduino:samd:mkrwan1300,8,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,8,0.0,0,0.0,0,0.0,0,0.0,,,,,88,0.03,0,0.0,,,,,,,,
arduino:samd:mkrwifi1010,184,0.07,0,0.0,184,0.07,0,0.0,184,0.07,0,0.0,184,0.07,0,0.0,184,0.07,0,0.0,184,0.07,0,0.0,88,0.03,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:nano_33_iot,184,0.07,0,0.0,184,0.07,0,0.0,184,0.07,0,0.0,184,0.07,0,0.0,184,0.07,0,0.0,184,0.07,0,0.0,96,0.04,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
esp32:esp32:esp32,200,0.02,0,0.0,216,0.02,0,0.0,216,0.02,0,0.0,216,0.02,0,0.0,224,0.02,0,0.0,216,0.02,0,0.0,112,0.01,0,0.0,,,,,,,,
esp8266:esp8266:huzzah,208,0.02,144,0.18,208,0.02,144,0.18,208,0.02,144,0.18,204,0.02,144,0.18,208,0.02,144,0.18,,,,,,,,,,,,,,,,

@pennam pennam marked this pull request as ready for review September 16, 2024 08:27
@pennam pennam added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Sep 16, 2024
@pennam pennam merged commit 7540146 into arduino-libraries:master Sep 16, 2024
23 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"ArduinoIoTCloudTCP::handle_SyncTime could not get valid time" caused by timezone diffrence
2 participants