Skip to content

Don't ack within 'read' if we are having a callback registered and reading from within the callback #45

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don't ack within 'read' if we are having a callback registered and reading from within the callback #45

wants to merge 1 commit into from

Conversation

aentinger
Copy link
Contributor

Otherwise ACK is sent twice - once during read and once after the completion of the callback _onMessage handler.

@aentinger aentinger added the type: imperfection Perceived defect in any part of project label Jul 28, 2020
@aentinger aentinger requested a review from facchinm July 28, 2020 13:50
@aentinger aentinger self-assigned this Jul 28, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@facchinm facchinm Awaiting requested review from facchinm

Assignees

@aentinger aentinger

Labels
type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aentinger