Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Rename Location to CellularLocation #12

Merged
merged 1 commit into from
May 9, 2024
Merged

Rename Location to CellularLocation #12

merged 1 commit into from
May 9, 2024

Conversation

pennam
Copy link
Contributor

@pennam pennam commented Apr 29, 2024

@pennam pennam marked this pull request as draft April 29, 2024 09:51
@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Apr 29, 2024
@pennam pennam force-pushed the location-rename branch from 34c092a to c651122 Compare May 2, 2024 09:25
@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

Memory usage change @ c651122

Board flash % RAM for global variables %
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/HTTPClient
flash		 % examples/HTTPClient
RAM for global variables		 % examples/HTTPSClient
flash		 % examples/HTTPSClient
RAM for global variables		 % examples/GetTime
flash		 % examples/GetTime
RAM for global variables		 % examples/GetLocation
flash		 % examples/GetLocation
RAM for global variables		 % examples/DeleteSMS
flash		 % examples/DeleteSMS
RAM for global variables		 % examples/ReceiveSMS
flash		 % examples/ReceiveSMS
RAM for global variables		 % examples/SendSMS
flash		 % examples/SendSMS
RAM for global variables		 % examples/ModemTerminal
flash		 % examples/ModemTerminal
RAM for global variables		 %
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV 
Board,examples/HTTPClient<br>flash,%,examples/HTTPClient<br>RAM for global variables,%,examples/HTTPSClient<br>flash,%,examples/HTTPSClient<br>RAM for global variables,%,examples/GetTime<br>flash,%,examples/GetTime<br>RAM for global variables,%,examples/GetLocation<br>flash,%,examples/GetLocation<br>RAM for global variables,%,examples/DeleteSMS<br>flash,%,examples/DeleteSMS<br>RAM for global variables,%,examples/ReceiveSMS<br>flash,%,examples/ReceiveSMS<br>RAM for global variables,%,examples/SendSMS<br>flash,%,examples/SendSMS<br>RAM for global variables,%,examples/ModemTerminal<br>flash,%,examples/ModemTerminal<br>RAM for global variables,%
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:renesas_portenta:portenta_c33,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0

@pennam pennam marked this pull request as ready for review May 2, 2024 14:38
@pennam pennam mentioned this pull request May 2, 2024
Merged
sebromero
sebromero requested changes May 7, 2024
View reviewed changes
Copy link
Contributor

@sebromero sebromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think CellularLocation is a bit misleading as this is a GPS location. @cristidragomir97 let's come up with something that is easier to grasp.

@cristidragomir97
Copy link
Contributor

I think CellularLocation is a bit misleading as this is a GPS location. @cristidragomir97 let's come up with something that is easier to grasp.

GeographicalLocation ?

@sebromero
Copy link
Contributor

I think CellularLocation is a bit misleading as this is a GPS location. @cristidragomir97 let's come up with something that is easier to grasp.

GeographicalLocation ?

Yes, how about Geolocation ?

sebromero
sebromero requested changes May 8, 2024
View reviewed changes
Copy link
Contributor

@sebromero sebromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I applied my suggestion

examples/GetLocation/GetLocation.ino Outdated Show resolved Hide resolved
examples/GetTime/GetTime.ino Outdated Show resolved Hide resolved
src/ArduinoCellular.cpp Outdated Show resolved Hide resolved
src/ArduinoCellular.cpp Outdated Show resolved Hide resolved
src/ArduinoCellular.h Outdated Show resolved Hide resolved
src/ArduinoCellular.h Outdated Show resolved Hide resolved
src/ArduinoCellular.h Outdated Show resolved Hide resolved
@pennam pennam force-pushed the location-rename branch from f81c535 to 51be44a Compare May 9, 2024 07:00
@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024

Memory usage change @ 51be44a

Board flash % RAM for global variables %
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/HTTPClient
flash		 % examples/HTTPClient
RAM for global variables		 % examples/HTTPSClient
flash		 % examples/HTTPSClient
RAM for global variables		 % examples/GetTime
flash		 % examples/GetTime
RAM for global variables		 % examples/GetLocation
flash		 % examples/GetLocation
RAM for global variables		 % examples/DeleteSMS
flash		 % examples/DeleteSMS
RAM for global variables		 % examples/ReceiveSMS
flash		 % examples/ReceiveSMS
RAM for global variables		 % examples/SendSMS
flash		 % examples/SendSMS
RAM for global variables		 % examples/ModemTerminal
flash		 % examples/ModemTerminal
RAM for global variables		 %
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV 
Board,examples/HTTPClient<br>flash,%,examples/HTTPClient<br>RAM for global variables,%,examples/HTTPSClient<br>flash,%,examples/HTTPSClient<br>RAM for global variables,%,examples/GetTime<br>flash,%,examples/GetTime<br>RAM for global variables,%,examples/GetLocation<br>flash,%,examples/GetLocation<br>RAM for global variables,%,examples/DeleteSMS<br>flash,%,examples/DeleteSMS<br>RAM for global variables,%,examples/ReceiveSMS<br>flash,%,examples/ReceiveSMS<br>RAM for global variables,%,examples/SendSMS<br>flash,%,examples/SendSMS<br>RAM for global variables,%,examples/ModemTerminal<br>flash,%,examples/ModemTerminal<br>RAM for global variables,%
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:renesas_portenta:portenta_c33,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0

@pennam pennam requested a review from sebromero May 9, 2024 07:28
@cristidragomir97 cristidragomir97 merged commit 2051e29 into arduino-libraries:main May 9, 2024
6 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sebromero sebromero Awaiting requested review from sebromero

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pennam @cristidragomir97 @sebromero @per1234