Allow watchdog kick while waiting for network #14

pennam · 2024-05-02T13:48:17Z

No description provided.

github-actions · 2024-05-02T14:03:09Z

Memory usage change @ b10b5e1

Board	flash	%	RAM for global variables	%
`arduino:mbed_portenta:envie_m7`	N/A	N/A	N/A	N/A
`arduino:renesas_portenta:portenta_c33`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0

Click for full report table

Board	`examples/HTTPClient` flash	%	`examples/HTTPClient` RAM for global variables	%	`examples/HTTPSClient` flash	%	`examples/HTTPSClient` RAM for global variables	%	`examples/GetTime` flash	%	`examples/GetTime` RAM for global variables	%	`examples/GetLocation` flash	%	`examples/GetLocation` RAM for global variables	%	`examples/DeleteSMS` flash	%	`examples/DeleteSMS` RAM for global variables	%	`examples/ReceiveSMS` flash	%	`examples/ReceiveSMS` RAM for global variables	%	`examples/SendSMS` flash	%	`examples/SendSMS` RAM for global variables	%	`examples/ModemTerminal` flash	%	`examples/ModemTerminal` RAM for global variables	%
`arduino:mbed_portenta:envie_m7`	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A
`arduino:renesas_portenta:portenta_c33`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0

Click for full report CSV

Board,examples/HTTPClient<br>flash,%,examples/HTTPClient<br>RAM for global variables,%,examples/HTTPSClient<br>flash,%,examples/HTTPSClient<br>RAM for global variables,%,examples/GetTime<br>flash,%,examples/GetTime<br>RAM for global variables,%,examples/GetLocation<br>flash,%,examples/GetLocation<br>RAM for global variables,%,examples/DeleteSMS<br>flash,%,examples/DeleteSMS<br>RAM for global variables,%,examples/ReceiveSMS<br>flash,%,examples/ReceiveSMS<br>RAM for global variables,%,examples/SendSMS<br>flash,%,examples/SendSMS<br>RAM for global variables,%,examples/ModemTerminal<br>flash,%,examples/ModemTerminal<br>RAM for global variables,%
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:renesas_portenta:portenta_c33,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0

sebromero

Just some small things :-) Otherwise looks good

sebromero · 2024-05-07T14:30:41Z

src/ArduinoCellular.cpp

@@ -214,12 +217,17 @@ bool ArduinoCellular::awaitNetworkRegistration(){
    if(this->debugStream != nullptr){
        this->debugStream->println("Waiting for network registration...");
    }
-    while (!modem.waitForNetwork()) {
+    while (!modem.waitForNetwork(20000L)) {


Please extract this constant into a constexpr

src/ArduinoCellular.cpp

sebromero

In our code we indent directives as if they were normal code to improve readabiltiy

src/ArduinoCellular.cpp

Co-authored-by: Sebastian Romero <s.romero.zh@gmail.com>

github-actions · 2024-05-08T09:20:52Z

Memory usage change @ d1c9d4a

Board	flash	%	RAM for global variables	%
`arduino:mbed_portenta:envie_m7`	N/A	N/A	N/A	N/A
`arduino:renesas_portenta:portenta_c33`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0

Click for full report table

Board	`examples/HTTPClient` flash	%	`examples/HTTPClient` RAM for global variables	%	`examples/HTTPSClient` flash	%	`examples/HTTPSClient` RAM for global variables	%	`examples/GetTime` flash	%	`examples/GetTime` RAM for global variables	%	`examples/GetLocation` flash	%	`examples/GetLocation` RAM for global variables	%	`examples/DeleteSMS` flash	%	`examples/DeleteSMS` RAM for global variables	%	`examples/ReceiveSMS` flash	%	`examples/ReceiveSMS` RAM for global variables	%	`examples/SendSMS` flash	%	`examples/SendSMS` RAM for global variables	%	`examples/ModemTerminal` flash	%	`examples/ModemTerminal` RAM for global variables	%
`arduino:mbed_portenta:envie_m7`	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A
`arduino:renesas_portenta:portenta_c33`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0

Click for full report CSV

Board,examples/HTTPClient<br>flash,%,examples/HTTPClient<br>RAM for global variables,%,examples/HTTPSClient<br>flash,%,examples/HTTPSClient<br>RAM for global variables,%,examples/GetTime<br>flash,%,examples/GetTime<br>RAM for global variables,%,examples/GetLocation<br>flash,%,examples/GetLocation<br>RAM for global variables,%,examples/DeleteSMS<br>flash,%,examples/DeleteSMS<br>RAM for global variables,%,examples/ReceiveSMS<br>flash,%,examples/ReceiveSMS<br>RAM for global variables,%,examples/SendSMS<br>flash,%,examples/SendSMS<br>RAM for global variables,%,examples/ModemTerminal<br>flash,%,examples/ModemTerminal<br>RAM for global variables,%
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:renesas_portenta:portenta_c33,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0

github-actions · 2024-05-09T07:05:37Z

Memory usage change @ 8691251

Board	flash	%	RAM for global variables	%
`arduino:mbed_portenta:envie_m7`	N/A	N/A	N/A	N/A
`arduino:renesas_portenta:portenta_c33`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0

Click for full report table

Board	`examples/HTTPClient` flash	%	`examples/HTTPClient` RAM for global variables	%	`examples/HTTPSClient` flash	%	`examples/HTTPSClient` RAM for global variables	%	`examples/GetTime` flash	%	`examples/GetTime` RAM for global variables	%	`examples/GetLocation` flash	%	`examples/GetLocation` RAM for global variables	%	`examples/DeleteSMS` flash	%	`examples/DeleteSMS` RAM for global variables	%	`examples/ReceiveSMS` flash	%	`examples/ReceiveSMS` RAM for global variables	%	`examples/SendSMS` flash	%	`examples/SendSMS` RAM for global variables	%	`examples/ModemTerminal` flash	%	`examples/ModemTerminal` RAM for global variables	%
`arduino:mbed_portenta:envie_m7`	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A
`arduino:renesas_portenta:portenta_c33`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0

Click for full report CSV

Board,examples/HTTPClient<br>flash,%,examples/HTTPClient<br>RAM for global variables,%,examples/HTTPSClient<br>flash,%,examples/HTTPSClient<br>RAM for global variables,%,examples/GetTime<br>flash,%,examples/GetTime<br>RAM for global variables,%,examples/GetLocation<br>flash,%,examples/GetLocation<br>RAM for global variables,%,examples/DeleteSMS<br>flash,%,examples/DeleteSMS<br>RAM for global variables,%,examples/ReceiveSMS<br>flash,%,examples/ReceiveSMS<br>RAM for global variables,%,examples/SendSMS<br>flash,%,examples/SendSMS<br>RAM for global variables,%,examples/ModemTerminal<br>flash,%,examples/ModemTerminal<br>RAM for global variables,%
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:renesas_portenta:portenta_c33,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0

sebromero

LGTM

aliphys · 2024-05-16T15:39:16Z

src/ArduinoCellular.cpp

+#if defined(ARDUINO_ARCH_MBED)
+  #include "Watchdog.h"
+#endif


Does this flag also cover https://github.com/arduino/ArduinoCore-renesas and not just https://github.com/arduino/ArduinoCore-mbed?

No it is mbed only. This change is related to ArduinoIotCloud integration that enables watchdog for mbed and samd boards but not for the renesas one.

pennam added 2 commits May 2, 2024 15:02

Reduce max wait time for network to 20s

90b3e2a

Add watchdog kick while waiting for the network

b10b5e1

pennam marked this pull request as ready for review May 2, 2024 14:38

pennam mentioned this pull request May 2, 2024

Add Cellular support using Arduino Mid Carrier arduino-libraries/ArduinoIoTCloud#452

Merged

per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels May 2, 2024

sebromero requested changes May 7, 2024

View reviewed changes

sebromero requested changes May 8, 2024

View reviewed changes

src/ArduinoCellular.cpp Outdated Show resolved Hide resolved

Apply correct indentation to directives

d1c9d4a

Co-authored-by: Sebastian Romero <s.romero.zh@gmail.com>

Add waitForNetworkTimeout constexpr

8691251

pennam requested a review from sebromero May 9, 2024 07:07

sebromero approved these changes May 9, 2024

View reviewed changes

cristidragomir97 merged commit 8503873 into arduino-libraries:main May 9, 2024
6 checks passed

aliphys reviewed May 16, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow watchdog kick while waiting for network #14

Allow watchdog kick while waiting for network #14

pennam commented May 2, 2024

github-actions bot commented May 2, 2024

sebromero left a comment

sebromero May 7, 2024

sebromero left a comment

github-actions bot commented May 8, 2024

github-actions bot commented May 9, 2024

sebromero left a comment

aliphys May 16, 2024

pennam May 16, 2024

Allow watchdog kick while waiting for network #14

Allow watchdog kick while waiting for network #14

Conversation

pennam commented May 2, 2024

github-actions bot commented May 2, 2024

sebromero left a comment

Choose a reason for hiding this comment

sebromero May 7, 2024

Choose a reason for hiding this comment

sebromero left a comment

Choose a reason for hiding this comment

github-actions bot commented May 8, 2024

github-actions bot commented May 9, 2024

sebromero left a comment

Choose a reason for hiding this comment

aliphys May 16, 2024

Choose a reason for hiding this comment

pennam May 16, 2024

Choose a reason for hiding this comment