Skip to content

Add more error checking to NTP packet processing #177

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add more error checking to NTP packet processing #177

wants to merge 3 commits into from

Conversation

MHotchin
Copy link

@MHotchin MHotchin commented Oct 1, 2022

Added error checks on the sending and receiving of the NTP packets.

@CLAassistant
Copy link

CLAassistant commented Oct 1, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

github-actions bot commented Oct 1, 2022

Memory usage change @ 5a93a54

Board flash % RAM for global variables %
esp8266:esp8266:huzzah 🔺 +48 - +48 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/Advanced
flash		 % examples/Advanced
RAM for global variables		 % examples/Basic
flash		 % examples/Basic
RAM for global variables		 % examples/IsTimeSet
flash		 % examples/IsTimeSet
RAM for global variables		 %
esp8266:esp8266:huzzah 48 0.0 0 0.0 48 0.0 0 0.0 48 0.0 0 0.0
Click for full report CSV 
Board,examples/Advanced<br>flash,%,examples/Advanced<br>RAM for global variables,%,examples/Basic<br>flash,%,examples/Basic<br>RAM for global variables,%,examples/IsTimeSet<br>flash,%,examples/IsTimeSet<br>RAM for global variables,%
esp8266:esp8266:huzzah,48,0.0,0,0.0,48,0.0,0,0.0,48,0.0,0,0.0

@MHotchin MHotchin mentioned this pull request Oct 1, 2022
Open
@per1234 per1234 linked an issue Oct 2, 2022 that may be closed by this pull request
NTPClient::sendNTPPacket() does not check whether this->_udp->beginPacket actually began. #162
Open
@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Oct 2, 2022
dependabot bot and others added 2 commits October 12, 2022 20:53
@dependabot
Bump geekyeggo/delete-artifact from 1 to 2
395e90d 
Bumps [geekyeggo/delete-artifact](https://github.com/geekyeggo/delete-artifact) from 1 to 2.
- [Release notes](https://github.com/geekyeggo/delete-artifact/releases)
- [Commits](GeekyEggo/delete-artifact@v1...v2)

---
updated-dependencies:
- dependency-name: geekyeggo/delete-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@MHotchin
Merge pull request #1 from MHotchin/dependabot/github_actions/geekyeg…
176b200 
…go/delete-artifact-2

Bump geekyeggo/delete-artifact from 1 to 2
@github-actions
Copy link

Memory usage change @ 176b200

Board flash % RAM for global variables %
esp8266:esp8266:huzzah 🔺 +48 - +48 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/Advanced
flash		 % examples/Advanced
RAM for global variables		 % examples/Basic
flash		 % examples/Basic
RAM for global variables		 % examples/IsTimeSet
flash		 % examples/IsTimeSet
RAM for global variables		 %
esp8266:esp8266:huzzah 48 0.0 0 0.0 48 0.0 0 0.0 48 0.0 0 0.0
Click for full report CSV 
Board,examples/Advanced<br>flash,%,examples/Advanced<br>RAM for global variables,%,examples/Basic<br>flash,%,examples/Basic<br>RAM for global variables,%,examples/IsTimeSet<br>flash,%,examples/IsTimeSet<br>RAM for global variables,%
esp8266:esp8266:huzzah,48,0.0,0,0.0,48,0.0,0,0.0,48,0.0,0,0.0

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NTPClient::sendNTPPacket() does not check whether this->_udp->beginPacket actually began.
3 participants
@MHotchin @CLAassistant @per1234