Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

added method to test if time was set correctly #71

Merged
merged 8 commits into from
May 25, 2021

Conversation

theandy94
Copy link
Contributor

Allows the user to test if the NTPClient has set the time correctly.
Useful for calculations where false positives are not acceptable.
I also added a new example to present a very simple usecase for this.

keywords.txt Outdated Show resolved Hide resolved
examples/IsTimeSet/IsTimeSet.ino Outdated Show resolved Hide resolved
examples/IsTimeSet/IsTimeSet.ino Outdated Show resolved Hide resolved
examples/IsTimeSet/IsTimeSet.ino Outdated Show resolved Hide resolved
examples/IsTimeSet/IsTimeSet.ino Outdated Show resolved Hide resolved
examples/IsTimeSet/IsTimeSet.ino Outdated Show resolved Hide resolved
theandy94 and others added 6 commits May 23, 2019 15:42
Co-Authored-By: per1234 <accounts@perglass.com>
Co-Authored-By: per1234 <accounts@perglass.com>
Co-Authored-By: per1234 <accounts@perglass.com>
Co-Authored-By: per1234 <accounts@perglass.com>
Co-Authored-By: per1234 <accounts@perglass.com>
Co-Authored-By: per1234 <accounts@perglass.com>
fabianonline added a commit to fabianonline/NTPClient that referenced this pull request Jun 5, 2019
NTPClient PR arduino-libraries#71: Add method to test if time was set correctly
@aentinger
Copy link
Contributor

@per1234 are the changes done to your satisfaction? If so please let me know and I'll merge this PR.

@CLAassistant
Copy link

CLAassistant commented Apr 9, 2021

CLA assistant check
All committers have signed the CLA.

@theandy94
Copy link
Contributor Author

I signed the CLA a day ago, but it still shows "Pending".
Any idea why that is?

@per1234 per1234 self-requested a review April 13, 2021 12:10
@aentinger
Copy link
Contributor

Any idea why that is?

Frankly, no. Can you try it again?

@per1234 per1234 dismissed their stale review April 14, 2021 05:27

All requested changes have been resolved. Thanks!

@per1234
Copy link
Contributor

per1234 commented Apr 14, 2021

are the changes done to your satisfaction? If so please let me know and I'll merge this PR.

Hi. I apologize to you both for my lack of response so long ago. I was out of action during that time period and never got caught up on my emails backlog after I got back to work.

The changes I requested have all been made.

@theandy94
Copy link
Contributor Author

Any idea why that is?

Frankly, no. Can you try it again?

Just did, it shows "You have agreed to the CLA for arduino-libraries/NTPClient" and then redirects me back to here.

@aentinger
Copy link
Contributor

aentinger commented Apr 14, 2021

theandy94 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@theandy94 - you've got a github account? Seems kind of obvious but that's the error message. Are you logged in when attempting to sign the CLA? You've been using a different email address for this commit than your github account?

CC @alranel

@theandy94
Copy link
Contributor Author

theandy94 commented Apr 14, 2021

theandy94 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@theandy94 - you've got a github account? Seems kind of obvious but that's the error message. Are you logged in when attempting to sign the CLA?

Yes, at the bottom there is the button "# with Github to agree". I #, then it says "You have agreed to the CLA for arduino-libraries/NTPClient" at the top.

Edit:
I've gone through my commits, and it seems I've used SSH to push the commit.
It still shows my name as "theandy94", but the gray github logo instead of my avatar.

After checking my SSH key (was generated an my mac) it shows my [Mac username]@[mymac].local as email address.
I tried to add it to my account, but it obviously cannot be verified.
Maybe that works.

Edit2:
It seems I configured a different email in git. Added that to my account, now my avatar is shown next to the commits.
I guess that was the culprit.
But still shows license pending down here.

Edit3:
Ok, rechecking now did the trick :D

@aentinger aentinger merged commit 367254d into arduino-libraries:master May 25, 2021
chrisy pushed a commit to chrisy/NTPClient that referenced this pull request Apr 16, 2022
added method to test if time was set correctly
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants