-
-
Notifications
You must be signed in to change notification settings - Fork 284
Added Eddystone-URL support #146
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
…ort BLE Service Data; changed Incomplete to Complete Service UUID list code in Advertising initialization, required by Eddystone-URL protocol; added (for debugging) getAdvertisingLength() and getAdvertising() to enable a Sketch viewing the Advertizing packet.
For an example sketch, see my Eddystone-URL Arduino 101 Sketch, which Advertises google.com via Eddystone/Physical-Web(tm) protocol . Should I add a version of this sketch as a CurieBLE example? |
I noticed I seem to have some typo in keywords.txt, because one of the new functions isn't highlighted in the IDE. Shall I correct that typo and push it to support-eddystone-url branch on my pull repo? ...or shall I wait for review to notice it. |
@bneedhamia sorry for the late review. Yes please go ahead and fix the typo. I will approve the pull request once that is done. Thanks. |
The keyword.txt corections are in. |
@calvinatintel please merge |
@Dan-Emutex @bigdinotech Excellent point. I'll take a look at @sandeepmistry Eddystone code and BLE library and if appropriate pull in the appropriate interfaces (in a new pull request). I wasn't aware of Sandeep's Eddystone code. I had skimmed Sandeep's BLE library before I started, and at least in a quick skim of the code at that time, I didn't see Service Data support in the advertising - obviously from his Eddystone code, it must be hiding in there somewhere. I'll give his Eddystone code and BLE library a good read-over. I wouldn't want to diverge from his code. Thanks again for the catch, |
@bneedhamia service data is currently controlled by calling This feature was left out of the CurieBLE library because controlling the advertisement data after @Dan-Emutex @bneedhamia thank you for bringing this discussion up. It would be great to continue to keep the CurieBLE API in sync with the BLEPeripheral library. |
Any updates on this topic |
@sandeepmistry , is service data broadcasting needed for the next BLE release? There was another discussion on similar topic here, |
EddystoneURL sample with Curie 2.0.2: |
Added Eddystone-URL support: added setAdvertisedServiceData() to support BLE Service Data; changed Incomplete to Complete Service UUID list code in Advertising initialization, required by Eddystone-URL protocol; added (for debugging and testing Advertising) getAdvertisingLength() and getAdvertising() to enable a Sketch to view the generated BLE Advertising packet.
This change allows an Arduino 101 to be a beacon, specifically an Eddystone-URL beacon, as used in Google's Physical Web(tm) project. See https://google.github.io/physical-web/