Fix Firmata crash, J-791. Peripheral discover profile failure, J-788 #391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, and thanks for your contribution! Unfortunately, your commit message does not follow our guidelines for considerate commit messages.
Please fix these issues by amending the commit ( (This message is automatically generated) |
sgbihu
changed the title
|
Hi @sgbihu, the bot is actually asking you to shorten the lines in your commit messages. I've re-written the guide here to be a little bit clearer. Please read it! |
sgbihu
force-pushed
the
master
branch
4 times, most recently
from
ba4ace3 to
2c2decd
Compare
SidLeung
changed the title
|
|
||
| void BLEStream::begin(...) |
There was a problem hiding this comment.
@sgbihu @SidLeung please see my comments in #377 (comment).
sgbihu
force-pushed
the
master
branch
2 times, most recently
from
c19f231 to
e08f1a7
Compare
|
I tested using the firmata library in this pull request firmata/arduino#335 Not the one in community sketches. Passed |
sgbihu
force-pushed
the
master
branch
3 times, most recently
from
c1ba714 to
11108f7
Compare
1. Add example sketch
libraries/CurieBLE/examples/peripheral/broadcast
…ice Git#384
1. The root cause is Nordic stack can't return long UUID when discover
- Change the discover process.
- Add read operation after discover returned invalid UUID.
…t triggered
1. Root casue: The callback regiter before the begin and the begin
reset the callback.
2. Solution: Remove it from the init method and init it when create.
1. Root casue: the stack need use connected device to get the state.
The current code used local address to get the link and get an error.
2. Solution: Use central's address to get connection state.
|
The above PR have been merged. Closing. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
38e6a29 and 1af2c57 are for bug fix. The other's are new developed feature.
The 38e6a29 try to resolve gitHub issue #377 and Jira 791
The 1af2c57 try to resolve #382 and Jira 788.