Skip to content

Jira 857, BLEPeripheral::connected() always returns false, git 444 #454

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2017
Merged

Jira 857, BLEPeripheral::connected() always returns false, git 444 #454

merged 1 commit into from
Feb 23, 2017

Conversation

SidLeung
Copy link
Contributor

Root casue:

  • The stack need use connected device to get the state.
  • The current code used local address to get the link and get an error.

Code mods:

  1. BLEPeripheral.cpp:
    • Use central's address to get connection state.

@sgbihu @SidLeung
Jira 857, BLEPeripheral::connected() always returns false, git 444
a2df179 
Root casue:
  - The stack need use connected device to get the state.
  - The current code used local address to get the link and get an error.

Code mods:

1. BLEPeripheral.cpp:
   - Use central's address to get connection state.
@SidLeung SidLeung self-assigned this Feb 23, 2017
@SidLeung SidLeung added this to the Deneb milestone Feb 23, 2017
@SidLeung
Copy link
Contributor Author

This PR is originated from #447

@eriknyquist , since you have approved this segment of code change at #447, please mark this PR approved.

@russmcinnis @noelpaz , no need re-test since you have tested this item using #447 for Jira 857.

@SidLeung SidLeung mentioned this pull request Feb 23, 2017
Closed
@SidLeung
Copy link
Contributor Author

@yashaswini-hanji , please merge to main trunk and close out Jira 857.

@ndgbuilder ndgbuilder merged commit a2df179 into arduino:master Feb 23, 2017
@yashaswini-hanji
Copy link
Contributor

PR merged and closed Jira 857

@sandeepmistry sandeepmistry mentioned this pull request Apr 7, 2017
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@eriknyquist eriknyquist eriknyquist approved these changes

@bigdinotech bigdinotech Awaiting requested review from bigdinotech

@russmcinnis russmcinnis Awaiting requested review from russmcinnis

@noelpaz noelpaz Awaiting requested review from noelpaz

Assignees

@SidLeung SidLeung

Labels
bug Under Review
Projects
None yet
Milestone
Deneb
Development

Successfully merging this pull request may close these issues.
5 participants
@SidLeung @yashaswini-hanji @eriknyquist @ndgbuilder @sgbihu