Skip to content

Jira 890, Allow BLE Descriptor reading to be blocking, git 478 #484

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Mar 23, 2017

Conversation

sgbihu
Copy link
Contributor

@sgbihu sgbihu commented Mar 17, 2017

Feature requested:
To make the reading of the Descriptor of a BLE Characteristic a blocking read method. The mechanism is similar to the the Characteristic read method. However, for Descriptor read(), it is always a blocking read.

Code Mods:

  1. libraries/CurieBLE/src/internal/BLEDescriptorImp.cpp:
    • Added a flag for the Descriptor read completion event to set in foreground.
    • Check on the Descriptor read completion event in the background as an exit condition for the read method.

@SidLeung SidLeung changed the title Implement the block call for descriptor read method Jira 890, Allow BLE Descriptor reading to be blocking, git 478 Mar 21, 2017
@SidLeung SidLeung self-assigned this Mar 21, 2017
@SidLeung SidLeung added this to the Deneb milestone Mar 21, 2017
@SidLeung
Copy link
Contributor

@bigdinotech @eriknyquist , please review the code change.

@russmcinnis @noelpaz , please perform system testing.

This feature is requested for Deneb.RC2 release.

@russmcinnis
Copy link
Contributor

System test passed PR490(471, 477, 480, 484 and 489). will unit test next.

Copy link
Contributor

@russmcinnis russmcinnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been system tested. The peripheral_explorer sketch was able to read() a descriptor successfully without the delay(1000). The read() took 95 msec. I can get some traces tomorrow. @SidLeung can see if this looks good enough.

@SidLeung
Copy link
Contributor

@russmcinnis , please save your traces in the Jira ticket for record.

@SidLeung SidLeung merged commit 33df47d into arduino:master Mar 23, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants