Skip to content

OTAUpdate: do not use Error enum to return error codes #197

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 14, 2024
Merged

OTAUpdate: do not use Error enum to return error codes #197

merged 1 commit into from
Feb 14, 2024

Conversation

pennam
Copy link
Contributor

@pennam pennam commented Nov 30, 2023

In this way if an error code changes in the wifi firmware there is no need to change this library

@pennam pennam mentioned this pull request Nov 30, 2023
Closed
@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Nov 30, 2023
@arduino arduino deleted a comment from github-actions bot Dec 5, 2023
@pennam
Copy link
Contributor Author

pennam commented Jan 9, 2024

ci build of the stable version is failing because OTA_ERROR_NONE is still unknown, but should be safe to merge.

@pennam pennam requested a review from facchinm January 9, 2024 11:21
@pennam pennam merged commit be29127 into arduino:main Feb 14, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@facchinm facchinm Awaiting requested review from facchinm

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pennam @per1234