WiFiC3 - apply new static IP settings in _config() (a patch way) #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it is a quick-dirty-patch. a proper solution should be done by the architect of the library
Care to provide a proper solution in form of a PR? |
|
I can do an alternative PR but it will be less transparent |
Let's take a look at it. |
|
the alternative: #209 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the PR a quick-dirty-patch to show what is missing.
a proper solution should be done by the maintainer of the library. maybe a
configorsetAddressmethod inCNetIf?discovered and tested with WiFiTest