Skip to content

ESPHost library - protobuf-c.c as source and not as precompiled #213

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2023
Merged

ESPHost library - protobuf-c.c as source and not as precompiled #213

merged 1 commit into from
Dec 20, 2023

Conversation

JAndrassy
Copy link
Contributor

there is no good reason to have protobuf-c.c precompiled. it compiles fast.
it was the only .o in libprotobufc.a

@JAndrassy JAndrassy mentioned this pull request Dec 18, 2023
Closed
aentinger
aentinger approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 You're right, there's barely a speed trade off, also now git submodule'd protobuf version matches the one compiled into your sketch.

@aentinger aentinger merged commit e13fdba into arduino:main Dec 20, 2023
@JAndrassy JAndrassy deleted the esphost_protobufc_as_source branch December 20, 2023 08:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@aentinger aentinger aentinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JAndrassy @aentinger