Skip to content

Use correct datatype for return value of FspTimer::get_available_timer() #288

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Use correct datatype for return value of FspTimer::get_available_timer() #288

merged 1 commit into from
Apr 8, 2024

Conversation

mast-eu
Copy link
Contributor

@mast-eu mast-eu commented Apr 7, 2024

This is a follow-up for #282 :

I missed in my previous PR that the return value from FspTimer::get_available_timer() is actually an int8, but in Arduino_LED_Matrix.h is stored as uint8.
Therefore the following if (added in #282) cannot work as intended:

uint8_t ch = FspTimer::get_available_timer(type);
if(ch == -1) {
return false;
}

This PR is to use the correct datatype. Ideally it should have been included in my previous PR.

@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Apr 7, 2024
@facchinm facchinm merged commit 923feca into arduino:main Apr 8, 2024
@mast-eu mast-eu deleted the compilerWarning2 branch April 8, 2024 16:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants