Skip to content

WiFiS3 and WiFIC3 Add wl definitions #439

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 4 commits into from
Feb 20, 2025
Merged

Conversation

pennam
Copy link
Contributor

@pennam pennam commented Feb 13, 2025

Fixes: #294

I've added only WL*_LENGTH definitions because even though they are mostly unused they are handy to declare arrays as explained in the issue.

@pennam pennam changed the title Add wl definitions WiFiS3 and WiFIC3 Add wl definitions Feb 13, 2025
@pennam pennam requested a review from maidnl February 13, 2025 11:46
Copy link
Contributor

@maidnl maidnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2 wrong comments to be reviewed

@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Feb 14, 2025
pennam and others added 4 commits February 19, 2025 17:49
Co-authored-by: Daniele <34984733+maidnl@users.noreply.github.com>
Co-authored-by: Daniele <34984733+maidnl@users.noreply.github.com>
@pennam pennam force-pushed the add-wl-definitions branch from c1117fa to b5bb105 Compare February 19, 2025 16:49
@pennam
Copy link
Contributor Author

pennam commented Feb 19, 2025

@maidnl fixed!

@pennam pennam requested a review from maidnl February 19, 2025 16:50
@pennam pennam merged commit dcba983 into arduino:main Feb 20, 2025
7 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WL Definitions Missing
3 participants