Skip to content

Some samd variants are missing SDA and SCL symbols #473

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
bperrybap opened this issue Nov 30, 2019 · 0 comments · Fixed by #486
Closed

Some samd variants are missing SDA and SCL symbols #473

bperrybap opened this issue Nov 30, 2019 · 0 comments · Fixed by #486
Assignees

Comments

@bperrybap
Copy link

bperrybap commented Nov 30, 2019

Some of the variants are missing SDA and SCL symbols in the associated variant.h header file.
These variants are missing the symbols:

  • mkrfox1200
  • mkrgsm1300
  • mkrwan1400
  • mkrzero

The other variants handle this by creating some constants:

static const uint8_t SDA = PIN_WIRE_SDA;
static const uint8_t SCL = PIN_WIRE_SCL;

Just after the PIN_WIRE_SDA and PIN_WIRE_SDA defines

The lack of these base/required symbols causes some arduino sketch/library s/w to fail to compile.

Rocketct added a commit to Rocketct/ArduinoCore-samd that referenced this issue Jan 15, 2020
added SDA and SCL variable in each samd variant.h

this fix: arduino#473
Rocketct added a commit to Rocketct/ArduinoCore-samd that referenced this issue Jan 15, 2020
Added SDA and SCL variables in variant.h of samd boards

This resolve: arduino#473
Rocketct added a commit that referenced this issue Jan 17, 2020
Added SDA and SCL variables in variant.h of samd boards

This resolve: #473
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants