Skip to content

Add support for zipped sketch with embedded libraries #223

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

facchinm
Copy link
Member

No description provided.

@ArduinoBot
Copy link
Contributor

✅ Build completed.

⬇️ Build URL: http://downloads.arduino.cc/PR/arduino-builder/arduino-builder-223.zip

ℹ️ To test this build:

  1. Replace arduino-builder binary (you can find it where you installed the IDE) with the provided one

@matthijskooijman
Copy link
Collaborator

Would this be a good moment to consider allowing a libraries subdirectory in all sketches? I think this PR adds support for this only for zipped sketches, which I would think is:

  1. Incosistent and leads to surprising behaviour
  2. A missed opportunity: Loading libraries from inside the sketch folder can greatly enhance the workflow of a complex sketch, for example when its dependency versions are kept using version control and git submodules.

@ArduinoBot
Copy link
Contributor

✅ Build completed.

⬇️ Build URL: http://downloads.arduino.cc/PR/arduino-builder/arduino-builder-223.zip

ℹ️ To test this build:

  1. Replace arduino-builder binary (you can find it where you installed the IDE) with the provided one

@ArduinoBot
Copy link
Contributor

✅ Build completed.

⬇️ Build URL: http://downloads.arduino.cc/PR/arduino-builder/arduino-builder-223.zip

ℹ️ To test this build:

  1. Replace arduino-builder binary (you can find it where you installed the IDE) with the provided one

@lmihalkovic
Copy link

Cool ... i see you have played with the idea... the IDE side is pretty straightforward .. i started doing the building blocks again on the 1.9.0 a couple days ago.

@lmihalkovic
Copy link

Using your suffix instead of mine (have not written support for the embedded libraries yet)

screen shot 2018-05-02 at 9 03 28 pm

screen shot 2018-05-02 at 9 02 57 pm

@ArduinoBot
Copy link
Contributor

✅ Build completed.

⬇️ Build URL: http://downloads.arduino.cc/PR/arduino-builder/arduino-builder-223.zip

ℹ️ To test this build:

  1. Replace arduino-builder binary (you can find it where you installed the IDE) with the provided one

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants