Skip to content

Fix binaries not being exported when using settings or env var #1056

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Nov 3, 2020

Conversation

silvanocerza
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce?

Bug fix.

  • What is the current behavior?

Setting either sketch.always_export_binaries in config file or ARDUINO_SKETCH_ALWAYS_EXPORT_BINARIES as env var to true would not export binaries when compile command is run.

  • What is the new behavior?

Setting both sketch.always_export_binaries in config file and ARDUINO_SKETCH_ALWAYS_EXPORT_BINARIES as env var to true works as expected and binaries are export when compile command is run.

  • Does this PR introduce a breaking change?

No.

  • Other information:

None.


See how to contribute

@silvanocerza
Copy link
Contributor Author

The verify-links check is currently failing because there's a link to the Arduino store that is currently down.

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great now. Thanks Silvano!

@silvanocerza silvanocerza merged commit e5d5d98 into master Nov 3, 2020
@silvanocerza silvanocerza deleted the scerza/fix-binaries-export branch November 3, 2020 13:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants