Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Expand property references in version property of platform.txt #1830

Merged
merged 5 commits into from
Aug 9, 2022

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Aug 9, 2022

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What is the new behavior?
    The version property is handled correctly.

@cmaglie cmaglie self-assigned this Aug 9, 2022
@cmaglie cmaglie added priority: high Resolution is a high priority type: imperfection Perceived defect in any part of project topic: CLI Related to the command line interface criticality: highest Of highest impact labels Aug 9, 2022
@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #1830 (860e3b3) into master (869c971) will decrease coverage by 0.02%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##           master    #1830      +/-   ##
==========================================
- Coverage   36.29%   36.26%   -0.03%     
==========================================
  Files         232      232              
  Lines       19497    19496       -1     
==========================================
- Hits         7076     7071       -5     
- Misses      11592    11594       +2     
- Partials      829      831       +2     
Flag Coverage Δ
unit 36.26% <40.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
arduino/cores/packagemanager/loader.go 71.79% <40.00%> (-0.57%) ⬇️
arduino/cores/packagemanager/package_manager.go 62.18% <0.00%> (-0.85%) ⬇️
internal/integrationtest/arduino-cli.go 80.34% <0.00%> (+1.15%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@per1234 per1234 added topic: code Related to content of the project itself and removed topic: CLI Related to the command line interface labels Aug 9, 2022
…egaavr/README.md

Co-authored-by: per1234 <accounts@perglass.com>
@cmaglie cmaglie requested review from per1234 and umbynos August 9, 2022 14:14
Co-authored-by: per1234 <accounts@perglass.com>
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Cristian!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
criticality: highest Of highest impact priority: high Resolution is a high priority topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Property references not expanded in version property of platform.txt
3 participants