Skip to content

Download library index as a combined archive+signature #1908

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Oct 6, 2022

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Oct 5, 2022

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)

What kind of change does this PR introduce?

Download library_index.json as a combined index+signature archive from the new URL: https://downloads.arduino.cc/libraries/library_index.tar.bz2

What is the current behavior?

Library index was downloaded separately from signature: this lead to sporadic incorrect signature verification.

What is the new behavior?

The index and signature are obtained from a single tar.bz2 archive (that also provide a bit of saving of the file size).

Does this PR introduce a breaking change, and is titled accordingly?

No

@cmaglie cmaglie requested review from per1234 and umbynos October 5, 2022 14:28
@cmaglie cmaglie self-assigned this Oct 5, 2022
@cmaglie cmaglie added type: enhancement Proposed improvement priority: high Resolution is a high priority criticality: low Of low impact topic: code Related to content of the project itself labels Oct 5, 2022
@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Base: 36.67% // Head: 36.62% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (138f9f9) compared to base (d27ba3d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1908      +/-   ##
==========================================
- Coverage   36.67%   36.62%   -0.05%     
==========================================
  Files         231      231              
  Lines       19684    19683       -1     
==========================================
- Hits         7219     7209      -10     
- Misses      11635    11646      +11     
+ Partials      830      828       -2     
Flag Coverage Δ
unit 36.62% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commands/instances.go 39.64% <100.00%> (-0.16%) ⬇️
arduino/resources/index.go 40.20% <0.00%> (-12.38%) ⬇️
arduino/cores/packagemanager/package_manager.go 66.58% <0.00%> (+0.75%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cmaglie cmaglie merged commit 797ed93 into arduino:master Oct 6, 2022
@cmaglie cmaglie deleted the library_index_as_archive branch October 6, 2022 13:55
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
criticality: low Of low impact priority: high Resolution is a high priority topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants