-
-
Notifications
You must be signed in to change notification settings - Fork 409
Added 'hardwareId' support to pluggable discovery #2065
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
I had a quick look over the PR, looks ok to me (did not look very closely, though). I do wonder: does this really need to be its own field? Would it not also make sense to put this into "properties"? I guess like this it allows defining additional semantics (i.e. same hardwareId -> same board instance), which would at best be part of a written convention if stored in properties? |
Codecov ReportBase: 36.67% // Head: 36.76% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2065 +/- ##
==========================================
+ Coverage 36.67% 36.76% +0.08%
==========================================
Files 228 228
Lines 19383 19385 +2
==========================================
+ Hits 7108 7126 +18
+ Misses 11442 11431 -11
+ Partials 833 828 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Because |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mainly cosmetic stuff
097c0dc
to
208fc42
Compare
Co-authored-by: Luca Bianconi <71259950+Bikappa@users.noreply.github.com>
208fc42
to
e34fffb
Compare
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)What kind of change does this PR introduce?
Add
hardwareId
support to the Arduino CLI. The documentation has been updated accordingly.See #2024 for details and rationale about the change in this PR.
What is the current behavior?
What is the new behavior?
Does this PR introduce a breaking change, and is titled accordingly?
No, it adds new features in a backward compatible way.
Other information
Close #2024