[breaking] Add post install script support for tools #2075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatteoPologruto
added
type: enhancement
Codecov ReportBase: 36.60% // Head: 36.60% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2075 +/- ##
=======================================
Coverage 36.60% 36.60%
=======================================
Files 229 229
Lines 19524 19539 +15
=======================================
+ Hits 7147 7153 +6
- Misses 11542 11549 +7
- Partials 835 837 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
cmaglie
requested changes
Feb 15, 2023
MatteoPologruto
force-pushed
the
post-install-script
branch
from
3cc7720 to
1e6966a
Compare
MatteoPologruto
force-pushed
the
post-install-script
branch
from
1e6966a to
81b6f64
Compare
MatteoPologruto
changed the title
MatteoPologruto
force-pushed
the
post-install-script
branch
2 times, most recently
from
cb73575 to
445ece9
Compare
MatteoPologruto
force-pushed
the
post-install-script
branch
from
445ece9 to
339242e
Compare
cmaglie
approved these changes
Feb 20, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)What kind of change does this PR introduce?
Code enhancement
What is the current behavior?
post_installscripts are not handled after the tool installation.What is the new behavior?
post_installscripts for tools are handled the same way the ones related to platforms are.Does this PR introduce a breaking change, and is titled accordingly?
No