Skip to content

feat: allow to show compilation properties without providing a sketch #2089

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 4 commits into from

Conversation

Bikappa
Copy link
Contributor

@Bikappa Bikappa commented Feb 27, 2023

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull
    Requests

    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

Other information

Fixes #1047

@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Patch coverage: 3.29% and no project coverage change.

Comparison is base (2900744) 35.01% compared to head (76e00bf) 35.02%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2089   +/-   ##
=======================================
  Coverage   35.01%   35.02%           
=======================================
  Files         232      232           
  Lines       20560    20593   +33     
=======================================
+ Hits         7200     7213   +13     
- Misses      12513    12535   +22     
+ Partials      847      845    -2     
Flag Coverage Δ
unit 35.02% <3.29%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commands/compile/compile.go 0.00% <0.00%> (ø)
internal/cli/arguments/sketch.go 0.00% <0.00%> (ø)
internal/cli/board/attach.go 0.00% <0.00%> (ø)
internal/cli/compile/compile.go 0.00% <0.00%> (ø)
internal/cli/debug/debug.go 0.00% <0.00%> (ø)
...acy/builder/fail_if_buildpath_equals_sketchpath.go 70.00% <0.00%> (-30.00%) ⬇️
legacy/builder/setup_build_properties.go 69.69% <100.00%> (+0.94%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Bikappa Bikappa force-pushed the feat/no-sketch-show-properties branch from ddaefa0 to 008ee78 Compare March 9, 2023 16:07
@Bikappa Bikappa marked this pull request as ready for review March 9, 2023 16:12
@Bikappa Bikappa marked this pull request as draft March 9, 2023 16:12
@Bikappa Bikappa force-pushed the feat/no-sketch-show-properties branch from 715a41b to 7a3eefd Compare March 13, 2023 15:55
@Bikappa Bikappa force-pushed the feat/no-sketch-show-properties branch from 227c435 to ff638bc Compare March 13, 2023 16:54
@Bikappa Bikappa requested a review from cmaglie March 17, 2023 10:53
@Bikappa Bikappa self-assigned this Mar 17, 2023
@cmaglie
Copy link
Member

cmaglie commented Mar 24, 2023

Actually, I don't think we need to go into the shenanigans of the builder anymore after #2082.
Probably we may also remove the "show properties" functionality from the legacy builder, but I need to try it.
I'll draft it in another PR so we can decide on the best approach.

@cmaglie
Copy link
Member

cmaglie commented Jun 5, 2023

Superseded by #2151

@cmaglie cmaglie closed this Jun 5, 2023
@cmaglie cmaglie deleted the feat/no-sketch-show-properties branch June 5, 2023 13:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: compile --show-properties without a sketch
2 participants