Fixed a couple of (very rare) race conditions #2112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The go-routine was spawned before the process was started. This means that p.Kill may read p.cmd.Process before it is written in p.Run.
cmaglie
added
topic: code
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2112 +/- ##
==========================================
+ Coverage 35.05% 35.17% +0.11%
==========================================
Files 232 232
Lines 20480 20498 +18
==========================================
+ Hits 7180 7210 +30
+ Misses 12455 12444 -11
+ Partials 845 844 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
umbynos
approved these changes
Mar 16, 2023
kittaakos
pushed a commit
to kittaakos/arduino-cli
that referenced
this pull request
Mar 21, 2023
* Fixed concurrent write to variables `err` and `n` * Fix concurrent access to p.cmd.Process The go-routine was spawned before the process was started. This means that p.Kill may read p.cmd.Process before it is written in p.Run.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
Fixed a couple of theoretical race conditions (they are detected by the race condition detector, but they are very unlikely to happen in a real-world scenario).
What is the current behavior?
What is the new behavior?
Does this PR introduce a breaking change, and is titled accordingly?
No
Other information