Skip to content

legacy: Arduino preprocess subroutine refactorization (part 2) #2191

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 6 commits into from
May 30, 2023

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented May 30, 2023

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

This PR is a try to split the bigger PR #2147 into smaller pieces to allow an easier review process.

What is the current behavior?

No changes

Does this PR introduce a breaking change, and is titled accordingly?

No

Other information

@cmaglie cmaglie added type: enhancement Proposed improvement topic: code Related to content of the project itself labels May 30, 2023
@cmaglie cmaglie self-assigned this May 30, 2023
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Patch coverage: 81.63% and project coverage change: -0.11 ⚠️

Comparison is base (15a5e88) 62.89% compared to head (bd60d11) 62.79%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2191      +/-   ##
==========================================
- Coverage   62.89%   62.79%   -0.11%     
==========================================
  Files         220      221       +1     
  Lines       19477    19463      -14     
==========================================
- Hits        12251    12221      -30     
- Misses       6141     6155      +14     
- Partials     1085     1087       +2     
Flag Coverage Δ
unit 62.79% <81.63%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...egacy/builder/add_additional_entries_to_context.go 58.62% <ø> (-2.67%) ⬇️
legacy/builder/create_cmake_rule.go 9.09% <ø> (+0.09%) ⬆️
legacy/builder/preprocess_sketch.go 0.00% <0.00%> (ø)
legacy/builder/types/context.go 97.53% <ø> (ø)
legacy/builder/types/types.go 78.12% <ø> (+4.59%) ⬆️
legacy/builder/container_add_prototypes.go 76.62% <66.66%> (-1.16%) ⬇️
internal/algorithms/slices.go 77.77% <77.77%> (ø)
legacy/builder/ctags/ctags_to_prototypes.go 84.84% <77.77%> (-2.66%) ⬇️
legacy/builder/gcc_preproc_runner.go 82.85% <83.33%> (+2.00%) ⬆️
legacy/builder/prototypes_adder.go 94.44% <88.88%> (-0.80%) ⬇️
... and 9 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cmaglie cmaglie merged commit 41bd2e4 into arduino:master May 30, 2023
@cmaglie cmaglie deleted the legacy-part2 branch May 30, 2023 15:47
@cmaglie cmaglie changed the title [skip-changelog] legacy: Arduino preprocess subroutine refactorization (part 2) legacy: Arduino preprocess subroutine refactorization (part 2) Sep 6, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants