Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Replace deprecated openpgp library #2333

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Replace deprecated openpgp library #2333

merged 2 commits into from
Sep 22, 2023

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Sep 22, 2023

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Dependency replace

What is the current behavior?

The openpgp library we were using has been marked as deprecated (see golang/go#44226)

What is the new behavior?

Replace it with a maintaned one

Does this PR introduce a breaking change, and is titled accordingly?

no

Other information

@umbynos umbynos added type: enhancement Proposed improvement topic: security Related to the protection of user data topic: infrastructure Related to project infrastructure labels Sep 22, 2023
@umbynos umbynos self-assigned this Sep 22, 2023
@umbynos umbynos force-pushed the replace-openpgp-lib branch from 1e82400 to cf9fa1a Compare September 22, 2023 10:00
@umbynos umbynos linked an issue Sep 22, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (dde3064) 63.04% compared to head (cf9fa1a) 63.04%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2333   +/-   ##
=======================================
  Coverage   63.04%   63.04%           
=======================================
  Files         201      201           
  Lines       19260    19260           
=======================================
  Hits        12142    12142           
  Misses       6065     6065           
  Partials     1053     1053           
Flag Coverage Δ
unit 63.04% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
arduino/security/signatures.go 65.51% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@umbynos umbynos merged commit 8b36949 into master Sep 22, 2023
@umbynos umbynos deleted the replace-openpgp-lib branch September 22, 2023 13:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
topic: infrastructure Related to project infrastructure topic: security Related to the protection of user data type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace golang.org/x/crypto/openpgp since it's deprecated
3 participants