Skip to content

fix wrong IndexFile truncate #2346

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Conversation

alessio-perugini
Copy link
Contributor

@alessio-perugini alessio-perugini commented Sep 28, 2023

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Fixes a regression that truncates every . in the filename.

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

Other information

@alessio-perugini alessio-perugini linked an issue Sep 28, 2023 that may be closed by this pull request
3 tasks
@alessio-perugini alessio-perugini self-assigned this Sep 28, 2023
@alessio-perugini alessio-perugini added the type: imperfection Perceived defect in any part of project label Sep 28, 2023
@alessio-perugini alessio-perugini marked this pull request as ready for review September 28, 2023 14:42
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6aa1be0) 63.04% compared to head (7ad3dab) 63.10%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2346      +/-   ##
==========================================
+ Coverage   63.04%   63.10%   +0.06%     
==========================================
  Files         201      201              
  Lines       19259    19263       +4     
==========================================
+ Hits        12141    12156      +15     
+ Misses       6064     6056       -8     
+ Partials     1054     1051       -3     
Flag Coverage Δ
unit 63.10% <87.50%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
arduino/resources/index.go 46.55% <87.50%> (+1.01%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified this fixes #2345.

Thanks Alessio!

@alessio-perugini alessio-perugini merged commit dc5c56e into master Oct 2, 2023
@alessio-perugini alessio-perugini deleted the 2345-package-index-filename-is-truncated-if-it-contains branch October 2, 2023 07:21
@2bndy5 2bndy5 mentioned this pull request Oct 13, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package index filename is truncated if it contains .
3 participants