Skip to content

Added {sketch_path} to build properties #2372

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Oct 17, 2023

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Adds the missing sketch_path variable to the build properties.

What is the current behavior?

{sketch_path} is missing from the build properties:

$ arduino-cli compile -b arduino:avr:uno --show-properties | grep sketch_path
$

What is the new behavior?

{sketch_path} is present in the build properties:

$ arduino-cli compile -b arduino:avr:uno --show-properties | grep sketch_path
sketch_path=/home/cmaglie/Arduino/Blink
$

Does this PR introduce a breaking change, and is titled accordingly?

No

Other information

Fix #2340

@cmaglie cmaglie self-assigned this Oct 17, 2023
@cmaglie cmaglie added type: imperfection Perceived defect in any part of project topic: build-process Related to the sketch build process labels Oct 17, 2023
@cmaglie cmaglie added this to the Arduino CLI v0.35.0 milestone Oct 17, 2023
@cmaglie cmaglie changed the title Added 'sketch_path' to build properties Added {sketch_path} to build properties Oct 17, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (a1fad63) 62.81% compared to head (c1494f1) 62.82%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2372   +/-   ##
=======================================
  Coverage   62.81%   62.82%           
=======================================
  Files         204      204           
  Lines       19308    19311    +3     
=======================================
+ Hits        12129    12132    +3     
  Misses       6119     6119           
  Partials     1060     1060           
Flag Coverage Δ
unit 62.82% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
arduino/builder/builder.go 65.78% <100.00%> (+0.30%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmaglie cmaglie merged commit bbfdc04 into arduino:master Oct 17, 2023
@cmaglie cmaglie deleted the fix_sketch_path branch October 17, 2023 14:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
topic: build-process Related to the sketch build process type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The sketch_path platform property is not generated
3 participants