Skip to content

Added integration test #282

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 9 commits into from
Jul 18, 2019
Merged

Added integration test #282

merged 9 commits into from
Jul 18, 2019

Conversation

mastrolinux
Copy link
Contributor

Cleaned up the whole mess with git.

@mastrolinux mastrolinux requested a review from masci July 16, 2019 13:46
Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's remove commented lines then :shipit:

@mastrolinux mastrolinux requested a review from masci July 17, 2019 09:59
Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a couple of comments

@@ -37,6 +38,9 @@ def test_command_lib_list():
result = run_command('lib list', '--format json')
assert '{}' == result.stdout

# def test_command_lib_download():
# result = run_command('lib download')

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's remove this before merging

Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@masci masci merged commit e249fbf into master Jul 18, 2019
@masci masci deleted the integration-test branch July 18, 2019 15:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants