Skip to content

fix: allow lib-install from git using revision hash as a reference #2882

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Apr 8, 2025

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Apr 7, 2025

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

A previous "fix" allowed the installation of a library from git by specifying a branch, but introduced a regression, making it impossible to install from git by specifying a revision hash.

What is the current behavior?

A library can not be installed from git using a revision hash, see #2860 for details

What is the new behavior?

It is now allowed to install from git using a revision hash.

Does this PR introduce a breaking change, and is titled accordingly?

Other information

Fix #2860

@cmaglie cmaglie self-assigned this Apr 7, 2025
@cmaglie cmaglie added topic: CLI Related to the command line interface phase: implementation Work is in the implementation phase criticality: medium Of moderate impact labels Apr 7, 2025
@cmaglie cmaglie changed the title fix: allow lib-install from git with revision hash fix: allow lib-install from git using revision hash as a reference Apr 7, 2025
@cmaglie cmaglie requested a review from a team April 7, 2025 15:26
Copy link

codecov bot commented Apr 7, 2025

Codecov Report

Attention: Patch coverage is 36.84211% with 12 lines in your changes missing coverage. Please review.

Project coverage is 67.82%. Comparing base (00a33b7) to head (39aca21).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...rnal/arduino/libraries/librariesmanager/install.go 36.84% 6 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2882      +/-   ##
==========================================
- Coverage   67.88%   67.82%   -0.06%     
==========================================
  Files         238      238              
  Lines       22410    22418       +8     
==========================================
- Hits        15212    15205       -7     
- Misses       6004     6012       +8     
- Partials     1194     1201       +7     
Flag Coverage Δ
unit 67.82% <36.84%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Apr 7, 2025
@cmaglie cmaglie merged commit 23ed1b1 into arduino:master Apr 8, 2025
98 checks passed
@cmaglie cmaglie deleted the fix-git-install-again branch April 8, 2025 13:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
criticality: medium Of moderate impact phase: implementation Work is in the implementation phase topic: CLI Related to the command line interface topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error installing Git Library with specific git sha hash
3 participants