Assert output is empty #297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mastrolinux
approved these changes
Jul 22, 2019
test/test_main.py
Outdated
| @@ -33,11 +33,14 @@ def test_command_help(): | |||
|
|
|||
|
|
|||
| def test_command_lib_list(): | |||
| """ | |||
| When ouput is empty, nothing is printed out, no matter the output format | |||
| """ | |||
| result = run_command('lib list') | |||
| assert result.ok | |||
| assert result.stderr == '' | |||
There was a problem hiding this comment.
also change this to
assert '' == result.stderr
to keep the style consistent
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up discussion at #96 we ensure that when command has no output nothing will be printed out, even if the selected format was JSON (
dockercli style).