Skip to content

Run integration tests in isolation #302

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 4 commits into from
Jul 23, 2019
Merged

Run integration tests in isolation #302

merged 4 commits into from
Jul 23, 2019

Conversation

masci
Copy link
Contributor

@masci masci commented Jul 23, 2019

To avoid messing with the filesystem of the user running the tests, execute the suite in a temporary folder that'll be wiped after the tests finish.

"""
When ouput is empty, nothing is printed out, no matter the output format
"""
result = run_command('lib list')
assert result.ok
assert '' == result.stderr
result = run_command('lib list', '--format json')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was the only function calling run_command with more than one arg, I've merged the two into a single list to match the rest of the code

Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@masci masci merged commit f8fb5de into master Jul 23, 2019
@masci masci deleted the massi/pytest branch July 23, 2019 12:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants